Bug 1298649 (interfasys/lognormalizer)
| Summary: | Review Request: php-interfasys-lognormalizer - Parses variables and converts them to string | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Remi Collet <fedora> | ||||||||
| Component: | Package Review | Assignee: | Shawn Iwinski <shawn> | ||||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||
| Severity: | medium | Docs Contact: | |||||||||
| Priority: | medium | ||||||||||
| Version: | rawhide | CC: | package-review, shawn | ||||||||
| Target Milestone: | --- | Flags: | shawn:
fedora-review+
|
||||||||
| Target Release: | --- | ||||||||||
| Hardware: | All | ||||||||||
| OS: | Linux | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2016-02-02 00:54:10 UTC | Type: | --- | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Bug Depends On: | |||||||||||
| Bug Blocks: | 1262185 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Remi Collet
2016-01-14 16:20:44 UTC
remi's scratch build of php-interfasys-lognormalizer-0-0.1.20150801gitd5e4c95.remi.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12548225 Having a "version" seems better :) https://github.com/interfasys/lognormalizer/issues/1 https://github.com/remicollet/remirepo/commit/1308df9c2593072342415ed00badf2b6b8a4d5f9 Spec: https://raw.githubusercontent.com/remicollet/remirepo/1308df9c2593072342415ed00badf2b6b8a4d5f9/php/php-interfasys-lognormalizer/php-interfasys-lognormalizer.spec Srpm: http://rpms.famillecollet.com/SRPMS/php-interfasys-lognormalizer-1.0-1.remi.src.rpm Created attachment 1116497 [details]
phpcompatinfo-full.log
phpCompatInfo version 4.5.2 DB built Nov 26 2015 14:29:15 CET
Created attachment 1116499 [details]
phpcompatinfo-lib.log
phpCompatInfo version 4.5.2 DB built Nov 26 2015 14:29:15 CET
Created attachment 1116501 [details]
fedora-review.txt
Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20
Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1298649
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, PHP, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated". 10 files have unknown license.
Actual license = AGPLv3
Spec license = AGPLv3+
From the source headers: https://github.com/interfasys/lognormalizer/blob/master/src/Normalizer.php * This file is licensed under the Affero General Public License version 3 or * later. See the COPYING file. So I think, this is really "AGPLv3+" (of course, COPYING is the v3) (In reply to Remi Collet from comment #7) > From the source headers: > > https://github.com/interfasys/lognormalizer/blob/master/src/Normalizer.php > > * This file is licensed under the Affero General Public License version 3 or > * later. See the COPYING file. > > So I think, this is really "AGPLv3+" (of course, COPYING is the v3) Sorry, I missed that. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 10 files have unknown license. [!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [!]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [!]: Buildroot is not present Note: Buildroot: present but not needed [!]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required As usual, remove EPEL 5 bits after initial import No blockers. ===== APPROVED ===== Thanks, SCM request open. Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/php-interfasys-lognormalizer php-interfasys-lognormalizer-1.0-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-70790f2076 php-interfasys-lognormalizer-1.0-1.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-5c10d2f4ec php-interfasys-lognormalizer-1.0-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-56f7c7209d php-interfasys-lognormalizer-1.0-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-70790f2076 php-interfasys-lognormalizer-1.0-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-56f7c7209d php-interfasys-lognormalizer-1.0-1.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-5c10d2f4ec php-interfasys-lognormalizer-1.0-1.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report. php-interfasys-lognormalizer-1.0-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. php-interfasys-lognormalizer-1.0-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. |