Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 1298932

Summary: lvm_vg_is_* do not return correct values
Product: Red Hat Enterprise Linux 6 Reporter: dfabian
Component: lvm2Assignee: Peter Rajnoha <prajnoha>
lvm2 sub component: Python API / liblvm (RHEL6) QA Contact: cluster-qe <cluster-qe>
Status: CLOSED ERRATA Docs Contact:
Severity: unspecified    
Priority: unspecified CC: agk, cmarthal, heinzm, jbrassow, msnitzer, prajnoha, prockai, rbednar, tasleson, zkabelac
Version: 6.7   
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: lvm2-2.02.140-1.el6 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-05-11 01:20:23 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description dfabian 2016-01-15 12:34:53 UTC
Description of problem:
The documentation in lvm2app.h specifies that lvm_vg_is_clustered() returns 1 if VG is clustered and 0 otherwise. However, the function returns 1024 if VG is clustered. This is because the macro vg_is_clustered in metadata-exported.h is set to

#define vg_is_clustered(vg) (vg_status((vg)) & CLUSTERED)

instead of

#define vg_is_clustered(vg) ((vg_status((vg)) & CLUSTERED) ? 1 : 0)

like in the case of for instance lv_is_locked

Other vg_is_* macros exhibit the similar issue.

The incorrect return value breaks the python wrapper as it does

rval = ( lvm_vg_is_clustered(self->vg) == 1) ? Py_True : Py_False;

which always returns Py_False regardless of the VG state.

How reproducible:
Always.

Steps to Reproduce:
Build and run thic C program
#include <lvm2app.h>
#include <stdio.h>

int main(int args, char**argv)
{
    lvm_t libh;
    vg_t vg = NULL;
    libh = lvm_init(NULL);
    vg = lvm_vg_open(libh, <clustered_vg_name>, "r", 0);
    printf("ret: %lu\n", lvm_vg_is_clustered(vg));
    lvm_vg_close(vg);
    lvm_quit(libh);
    return 0;
}

The program returns "ret: 1024".

Actual results:


Expected results:
lvm_vg_is_clustered() and others should return 1 if the specific flag is set in the VG.

Additional info:

Comment 2 Peter Rajnoha 2016-01-15 13:15:30 UTC
Nice catch! We'll certainly fix this, thanks for the report.

Comment 6 Roman Bednář 2016-03-03 10:09:34 UTC
Verified as SanityOnly. No new issues observed during regression testing.

Comment 8 errata-xmlrpc 2016-05-11 01:20:23 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2016-0964.html