Bug 1298932
| Summary: | lvm_vg_is_* do not return correct values | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 6 | Reporter: | dfabian |
| Component: | lvm2 | Assignee: | Peter Rajnoha <prajnoha> |
| lvm2 sub component: | Python API / liblvm (RHEL6) | QA Contact: | cluster-qe <cluster-qe> |
| Status: | CLOSED ERRATA | Docs Contact: | |
| Severity: | unspecified | ||
| Priority: | unspecified | CC: | agk, cmarthal, heinzm, jbrassow, msnitzer, prajnoha, prockai, rbednar, tasleson, zkabelac |
| Version: | 6.7 | ||
| Target Milestone: | rc | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | lvm2-2.02.140-1.el6 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-05-11 01:20:23 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
Nice catch! We'll certainly fix this, thanks for the report. Fixed here: https://git.fedorahosted.org/cgit/lvm2.git/commit/?id=7559af2334a619bc3dcbf558152841b2695c8616 Verified as SanityOnly. No new issues observed during regression testing. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHBA-2016-0964.html |
Description of problem: The documentation in lvm2app.h specifies that lvm_vg_is_clustered() returns 1 if VG is clustered and 0 otherwise. However, the function returns 1024 if VG is clustered. This is because the macro vg_is_clustered in metadata-exported.h is set to #define vg_is_clustered(vg) (vg_status((vg)) & CLUSTERED) instead of #define vg_is_clustered(vg) ((vg_status((vg)) & CLUSTERED) ? 1 : 0) like in the case of for instance lv_is_locked Other vg_is_* macros exhibit the similar issue. The incorrect return value breaks the python wrapper as it does rval = ( lvm_vg_is_clustered(self->vg) == 1) ? Py_True : Py_False; which always returns Py_False regardless of the VG state. How reproducible: Always. Steps to Reproduce: Build and run thic C program #include <lvm2app.h> #include <stdio.h> int main(int args, char**argv) { lvm_t libh; vg_t vg = NULL; libh = lvm_init(NULL); vg = lvm_vg_open(libh, <clustered_vg_name>, "r", 0); printf("ret: %lu\n", lvm_vg_is_clustered(vg)); lvm_vg_close(vg); lvm_quit(libh); return 0; } The program returns "ret: 1024". Actual results: Expected results: lvm_vg_is_clustered() and others should return 1 if the specific flag is set in the VG. Additional info: