Bug 1298992

Description of problem:
Applying whatever change to /etc/gutterball/gutterball.conf or to /etc/candlepin/candlepin.conf causes subsequent run of katello-installer to fail with error:

 /Stage[main]/Gutterball::Database/Postgresql::Server::Db[gutterball]/Postgresql::Server::Database[gutterball]/Exec[/usr/bin/createdb --port='5432' --owner='postgres' --template=template0 --encoding 'utf8' --locale=en_US.utf8  'gutterball']: Failed to call refresh: /usr/bin/createdb --port='5432' --owner='postgres' --template=template0 --encoding 'utf8' --locale=en_US.utf8  'gutterball' returned 1 instead of one of [0]

See Additional info for explanation.


Version-Release number of selected component (if applicable):
katello-installer-2.3.22-1.el7sat.noarch


How reproducible:
100%


Steps to Reproduce:
1. Have Sat6 installed
2. echo >> /etc/gutterball/gutterball.conf
(or apply any other change there)

(alternative reproducer: replace gutterball.conf by candlepin.conf)

3. katello-installer


Actual results:
installer fails with:
 /Stage[main]/Gutterball::Database/Postgresql::Server::Db[gutterball]/Postgresql::Server::Database[gutterball]/Exec[/usr/bin/createdb --port='5432' --owner='postgres' --template=template0 --encoding 'utf8' --locale=en_US.utf8  'gutterball']: Failed to call refresh: /usr/bin/createdb --port='5432' --owner='postgres' --template=template0 --encoding 'utf8' --locale=en_US.utf8  'gutterball' returned 1 instead of one of [0]

katello-installer.log having:

[ERROR 2015-12-01 15:33:24 main]  /Stage[main]/Gutterball::Database/Postgresql::Server::Db[gutterball]/Postgresql::Server::Database[gutterball]/Exec[/usr/bin/createdb --port='5432' --owner='postgres' --template=template0 --encoding 'utf8' --locale=en_US.utf8  'gutterball']: Failed to call refresh: /usr/bin/createdb --port='5432' --owner='postgres' --template=template0 --encoding 'utf8' --locale=en_US.utf8  'gutterball' returned 1 instead of one of [0]


Expected results:
installer runs fine


Additional info:
why is createdb called? because:

[ INFO 2015-12-01 15:33:24 main]  /Stage[main]/Gutterball::Database/Postgresql::Server::Db[gutterball]/Postgresql::Server::Database[gutterball]/Postgresql_psql[Check for existence of db 'gutterball']: Scheduling refresh of Exec[/usr/bin/createdb --port='5432' --owner='postgres' --template=template0 --encoding 'utf8' --locale=en_US.utf8  'gutterball']

that is because:

[ INFO 2015-12-01 15:33:24 main]  Postgresql::Server::Database[gutterball]: Scheduling refresh of Postgresql_psql[Check for existence of db 'gutterball']

that is because:

[ INFO 2015-12-01 15:33:21 main]  Postgresql::Server::Db[gutterball]: Scheduling refresh of Postgresql::Server::Database[gutterball]

that is because:

[ INFO 2015-12-01 15:33:21 main]  Class[Gutterball::Database]: Scheduling refresh of Postgresql::Server::Db[gutterball]

that is because:

[ INFO 2015-12-01 15:33:21 main]  Class[Gutterball::Config]: Scheduling refresh of Class[Gutterball::Database]

that is because:

[DEBUG 2015-12-01 15:33:21 main]  /Stage[main]/Gutterball::Config/File[/etc/gutterball/gutterball.conf]: The container Class[Gutterball::Config] will propagate my refresh event

So when puppet is forced to revert back a change in gutterball.conf or candlepin.conf, it ends up in attempt to createdb for gutterball.

Interestingly, createdb for candlepin is _not_ to be refreshed. So some katello-installer setting from candlepin can be carried to gutterball to fix this BZ.