Bug 1299141

Summary:	fetch-crl-boot ignores /etc/sysconfig/fetch-crl on EL7
Product:	[Fedora] Fedora EPEL	Reporter:	jouvin
Component:	fetch-crl	Assignee:	Steve Traylen <steve.traylen>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	el6	CC:	davidg, steve.traylen
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	fetch-crl-3.0.17-3.fc23 fetch-crl-3.0.17-3.el7 fetch-crl-3.0.17-3.el6	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-02-11 13:22:11 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description jouvin 2016-01-16 15:00:47 UTC

Description of problem:

The file /etc/systemd/system/multi-user.target.wants/fetch-crl-boot.service is missing the line to load /etc/sysconfig/fetch-crl... In addition the same file doesn't contain the fix introduced in 3.0.13 to be able to pass fetch-crl-boot specific options defined in /etc/sysconfig/fetch-crl (this is in particular useful to ignore CRL retrieval errors at boot time (see https://bugzilla.nikhef.nl/show_bug.cgi?id=12). The following 2 lines in the [service] section should fix the problem;

EnvironmentFile=/etc/sysconfig/fetch-crl
ExecStart=/usr/sbin/fetch-crl -q $FETCHCRL_OPTIONS $FETCHCRL_BOOT_OPTIONS

If the variable is undefined, as with chkconfig, this causes no problem.

Cheers,

Michel

Version-Release number of selected component (if applicable):

3.0.16

How reproducible:

Always

Steps to Reproduce:
1. Need a CRL that fails to be uploaded (seems the case with the Egyptian CRL these days...) 
2. rm /var/lock/subsystem/fetch-crl-boot
3. systemctl start fetch-crl-boot
4. echo $?

Actual results:

1

Expected results:

0

Additional info:

This is quite critical when using configuration management tools like Puppet and Quattor which may care of the status returned to decide if the component has run successfully and let dependencies be configured.

Comment 1 Fedora Update System 2016-01-18 08:45:54 UTC

fetch-crl-3.0.17-3.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-189d7514d8

Comment 2 Fedora Update System 2016-01-18 08:45:54 UTC

fetch-crl-3.0.17-3.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-81c1985601

Comment 3 Fedora Update System 2016-01-18 08:46:00 UTC

fetch-crl-3.0.17-3.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-a219678d44

Comment 4 Fedora Update System 2016-01-20 03:18:57 UTC

fetch-crl-3.0.17-3.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-189d7514d8

Comment 5 Fedora Update System 2016-01-20 03:20:30 UTC

fetch-crl-3.0.17-3.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-a219678d44

Comment 6 Fedora Update System 2016-01-20 03:55:21 UTC

fetch-crl-3.0.17-3.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-81c1985601

Comment 7 Fedora Update System 2016-02-11 13:22:07 UTC

fetch-crl-3.0.17-3.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

Comment 8 Fedora Update System 2016-02-11 17:55:21 UTC

fetch-crl-3.0.17-3.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.

Comment 9 Fedora Update System 2016-02-11 18:24:40 UTC

fetch-crl-3.0.17-3.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.