Bug 1299526
| Summary: | [RFE] Engine setup should update the HEAP_MIN&HEAP_MAX default values if memory size changed. | ||
|---|---|---|---|
| Product: | [oVirt] ovirt-engine | Reporter: | Nikolai Sednev <nsednev> |
| Component: | Setup.Engine | Assignee: | Sandro Bonazzola <sbonazzo> |
| Status: | CLOSED WONTFIX | QA Contact: | Pavel Stehlik <pstehlik> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 3.6.2.5 | CC: | bugs, didi, lveyde, nsednev, rmartins, sbonazzo, stirabos, ylavi |
| Target Milestone: | --- | Flags: | rule-engine:
planning_ack?
rule-engine: devel_ack? rule-engine: testing_ack? |
| Target Release: | --- | ||
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| URL: | http://permalink.gmane.org/gmane.comp.emulators.ovirt.engine.patches/295828 | ||
| Whiteboard: | integration | ||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-01-20 12:19:53 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | Integration | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Nikolai Sednev
2016-01-18 15:16:33 UTC
Adding some related bugs to this RFE: https://bugzilla.redhat.com/show_bug.cgi?id=1185411 https://bugzilla.redhat.com/show_bug.cgi?id=1188972 https://bugzilla.redhat.com/show_bug.cgi?id=1113771 *** Bug 1299523 has been marked as a duplicate of this bug. *** (copied from bug 1299523 comment 2) (In reply to Nikolai Sednev from comment #0) > Expected results: > HEAP_MIN&HEAP_MAX of engine&DWH&reports should get changed automatically in > case of RAM increased/decreased, unless customer manually setting those > values, preferably via engine-setup itself, hence this requires from > engine-setup to expose those values for manual changes, which are currently > consealed. Some ideas/thoughts: 1. Perhaps do that during engine restart instead of engine-setup. 2. Provide means to users to prevent us from automatically changing. Probably including retroactively (users that manually set it already), not sure how. 3. Add vars ENGINE_HEAP_PERCENT_MIN and ENGINE_HEAP_PERCENT_MAX . Use -Xms = max(ENGINE_HEAP_MIN, ENGINE_HEAP_PERCENT_MIN*physmem/100), similarly for -Xmx. If a admin adds memory to the host I expect them to also change the default. I don't think we should have dynamic defaults, it can have unexpected results. We're not exposing these settings in any way possible to the user, and we have them for DWH+engine+jasper-reports, we require documentation on this as well. Regarding adding/removing memory, what do you expect from customer to do if he'll remove the memory or if it'll be a VM with hot-plug RAM? (In reply to Nikolai Sednev from comment #5) > We're not exposing these settings in any way possible to the user, and we > have them for DWH+engine+jasper-reports, we require documentation on this as > well. Open a bug to extend the existing one for anything missing. > Regarding adding/removing memory, what do you expect from customer to do if > he'll remove the memory or if it'll be a VM with hot-plug RAM? Do manual changes to JBoss to update memory amount. (In reply to Yaniv Dary from comment #6) > (In reply to Nikolai Sednev from comment #5) > > We're not exposing these settings in any way possible to the user, and we > > have them for DWH+engine+jasper-reports, we require documentation on this as > > well. > > Open a bug to extend the existing one for anything missing. > > > Regarding adding/removing memory, what do you expect from customer to do if > > he'll remove the memory or if it'll be a VM with hot-plug RAM? > > Do manual changes to JBoss to update memory amount. Is there any option to reopen this bug? Customers will hit the same issue during their bare-bone->HE-VM migrations: I'm hitting this bug again i case of following the http://brq-setup.rhev.lab.eng.brq.redhat.com/ovirt-engine/docs/manual/en_US/html/Self-Hosted_Engine_Guide/chap-Migrating_from_Bare_Metal_to_a_RHEL-Based_Self-Hosted_Environment.html , during migration of engine from bare-bone host to HE-VM. I have initial ammount of 32Gig of RAM on bare-bone and during HE-VM deployment I'm chosing 4Gig for the HE-VM, because of the fact that hosted-engine-host has 32Gig and it have to share it with guest-VMs. Engine fails to get started on VM, as it takes the original MIN&MAX values of 8011M from /etc/ovirt-engine/engine.conf.d/10-setup-java.conf, received from the restored engine DB."Starting oVirt Engine: [FAILED]". Bottom line: After backup succeeded on HE-VM, it gained previous RAM values of 8011M from engine database, for MIN=8011M and MAX=8011M, so I had to manually edit the "vi /etc/ovirt-engine/engine.conf.d/10-setup-java.conf" and set both min and max to 1024M, otherwise engine-setup fails to start ovirt-engine "Starting oVirt Engine: [FAILED]". (In reply to Nikolai Sednev from comment #7) > (In reply to Yaniv Dary from comment #6) > > (In reply to Nikolai Sednev from comment #5) > > > We're not exposing these settings in any way possible to the user, and we > > > have them for DWH+engine+jasper-reports, we require documentation on this as > > > well. > > > > Open a bug to extend the existing one for anything missing. > > > > > Regarding adding/removing memory, what do you expect from customer to do if > > > he'll remove the memory or if it'll be a VM with hot-plug RAM? > > > > Do manual changes to JBoss to update memory amount. > > Is there any option to reopen this bug? > Customers will hit the same issue during their bare-bone->HE-VM migrations: > > I'm hitting this bug again i case of following the > http://brq-setup.rhev.lab.eng.brq.redhat.com/ovirt-engine/docs/manual/en_US/ > html/Self-Hosted_Engine_Guide/chap-Migrating_from_Bare_Metal_to_a_RHEL- > Based_Self-Hosted_Environment.html , during migration of engine from > bare-bone host to HE-VM. I have initial ammount of 32Gig of RAM on bare-bone > and during HE-VM deployment I'm chosing 4Gig for the HE-VM, because of the > fact that hosted-engine-host has 32Gig and it have to share it with > guest-VMs. > Engine fails to get started on VM, as it takes the original MIN&MAX values > of 8011M from /etc/ovirt-engine/engine.conf.d/10-setup-java.conf, received > from the restored engine DB."Starting oVirt Engine: [FAILED]". Please add a docs bug to mind this in the guide. > > Bottom line: > After backup succeeded on HE-VM, it gained previous RAM values of 8011M from > engine database, for MIN=8011M and MAX=8011M, so I had to manually edit the > "vi /etc/ovirt-engine/engine.conf.d/10-setup-java.conf" and set both min and > max to 1024M, otherwise engine-setup fails to start ovirt-engine "Starting > oVirt Engine: [FAILED]". Didi should we do something in restore for this issue in comment 7? IMO no. The doc should say "The new engine VM should have the same amount of memory as the physical host we migrate from". We can also have a KB article saying how to decrease the default value. Please open a docs bug on KB and guide. |