Bug 1299533

Summary: Review Request: perl-App-Cme - Check or edit configuration data with Config::Model
Product: [Fedora] Fedora Reporter: Jitka Plesnikova <jplesnik>
Component: Package ReviewAssignee: Petr Šabata <psabata>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: package-review, psabata
Target Milestone: ---Flags: psabata: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: perl-App-Cme-1.009-2.fc24 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-01-20 14:49:24 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1290794    

Description Jitka Plesnikova 2016-01-18 15:27:02 UTC 
Spec URL: https://jplesnik.fedorapeople.org/perl-App-Cme/perl-App-Cme.spec
SRPM URL: https://jplesnik.fedorapeople.org/perl-App-Cme/perl-App-Cme-1.009-1.fc24.src.rpm
Description:
cme and Config::Model are quite modular. The configuration data that
you can edit depend on the other Config::Model distributions installed
on your system.

Fedora Account System Username: jplesnik
Comment 1 Petr Šabata 2016-01-19 16:00:46 UTC 
* Missing buildtime dependencies:
  - coreutils, used in the SPEC file, line 65
  - sed, used in the SPEC file, line 54

* You only need Config::Model 2.063 for build; 2.068 is required by the update
  command which isn't tested.

* Config::Model::FuseUI could be a recommended runtime dependency.

* You might want to filter out that `perl(Config::Model) >= 2.063' runtime
  dependency.
Comment 2 Jitka Plesnikova 2016-01-20 08:06:35 UTC 
Updated

Spec URL: https://jplesnik.fedorapeople.org/perl-App-Cme/perl-App-Cme.spec
SRPM URL: https://jplesnik.fedorapeople.org/perl-App-Cme/perl-App-Cme-1.009-2.fc24.src.rpm
Comment 3 Petr Šabata 2016-01-20 11:43:37 UTC 
All four points addressed.  Approving.
Comment 4 Gwyn Ciesla 2016-01-20 14:21:37 UTC 
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/perl-App-Cme
Comment 5 Jitka Plesnikova 2016-01-20 14:49:24 UTC 
Thank you for the review and the repository.