Bug 1299583

Summary: Review Request: perl-Number-Fraction - Perl extension to model fractions
Product: [Fedora] Fedora Reporter: Petr Šabata <psabata>
Component: Package ReviewAssignee: Jitka Plesnikova <jplesnik>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: jplesnik, package-review
Target Milestone: ---Flags: jplesnik: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-01-30 18:23:07 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 1296524    

Description Petr Šabata 2016-01-18 16:57:02 UTC
Spec URL: https://psabata.fedorapeople.org/pkgs/perl-Number-Fraction/perl-Number-Fraction.spec
SRPM URL: https://psabata.fedorapeople.org/pkgs/perl-Number-Fraction/perl-Number-Fraction-2.00-1.fc23.src.rpm
Description:
Number::Fraction allows you to work with fractions (i.e. rational numbers)
in your Perl programs in a very natural way.
Fedora Account System Username: psabata

Comment 1 Jitka Plesnikova 2016-01-19 09:43:09 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

$ rpm -qp --requires perl-Number-Fraction-2.00-1.fc24.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.22.1)
      1 perl(:VERSION) >= 5.6.0
      1 perl(Carp)
      1 perl(Moose)
      1 perl(overload)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1

Binary requires are Ok.

$ rpm -qp --provides perl-Number-Fraction-2.00-1.fc24.noarch.rpm | sort | uniq -c
      1 perl(Number::Fraction) = 2.00
      1 perl-Number-Fraction = 2.00-1.fc24

Binary provides are Ok.

$ rpmlint ./perl-Number-Fraction*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

Rpmlint is ok

BuildRequires are almost ok
FIX: Please remove BR 'make', it is not used.

Otherwise the package looks good.
APPROVED.

Comment 2 Gwyn Ciesla 2016-01-19 13:14:48 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/perl-Number-Fraction

Comment 3 Fedora Update System 2016-01-19 13:51:18 UTC
perl-Number-Fraction-2.00-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-f2dc56303b

Comment 4 Fedora Update System 2016-01-19 13:51:59 UTC
perl-Number-Fraction-2.00-1.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-2dfe3eff68

Comment 5 Fedora Update System 2016-01-20 23:58:21 UTC
perl-Number-Fraction-2.00-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-f2dc56303b

Comment 6 Fedora Update System 2016-01-21 06:24:52 UTC
perl-Number-Fraction-2.00-1.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-2dfe3eff68

Comment 7 Fedora Update System 2016-01-30 18:23:04 UTC
perl-Number-Fraction-2.00-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

Comment 8 Fedora Update System 2016-02-01 06:33:07 UTC
perl-Number-Fraction-2.00-1.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.