Bug 1299809
Summary: | CPU Right Size recommendations only take into account CPU sockets, not cores per socket | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Red Hat CloudForms Management Engine | Reporter: | Peter McGowan <pmcgowan> | ||||||
Component: | C&U Capacity and Utilization | Assignee: | Adam Grare <agrare> | ||||||
Status: | CLOSED CURRENTRELEASE | QA Contact: | Dmitry Misharov <dmisharo> | ||||||
Severity: | high | Docs Contact: | |||||||
Priority: | medium | ||||||||
Version: | 5.5.0 | CC: | agrare, benglish, clasohm, cpelland, dlamotta, gblomqui, jhardy, jprause, kmorey, nstephan, obarenbo, simaishi | ||||||
Target Milestone: | GA | Keywords: | TestOnly, ZStream | ||||||
Target Release: | 5.7.0 | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Whiteboard: | c&u | ||||||||
Fixed In Version: | 5.7.0.0 | Doc Type: | Bug Fix | ||||||
Doc Text: | Story Points: | --- | |||||||
Clone Of: | |||||||||
: | 1348631 (view as bug list) | Environment: | |||||||
Last Closed: | 2017-01-11 20:02:35 UTC | Type: | Bug | ||||||
Regression: | --- | Mount Type: | --- | ||||||
Documentation: | --- | CRM: | |||||||
Verified Versions: | Category: | --- | |||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||
Embargoed: | |||||||||
Bug Depends On: | |||||||||
Bug Blocks: | 1348631 | ||||||||
Attachments: |
|
Description
Peter McGowan
2016-01-19 10:09:45 UTC
New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/b06a35f1342839a7a266f2aa8ad56290c86fde69 commit b06a35f1342839a7a266f2aa8ad56290c86fde69 Author: Adam Grare <agrare> AuthorDate: Mon Jan 25 11:01:59 2016 -0500 Commit: Adam Grare <agrare> CommitDate: Mon Jan 25 20:06:55 2016 -0500 Use cpu_total_cores for vm cpu right_size CPU right size recommendation was reporting a VM with 1 socket and 4 cores as having 1 total CPU. Use cpu_total_cores instead of num_cpu to correctly report the total number of logical CPUs. https://bugzilla.redhat.com/show_bug.cgi?id=1299809 app/models/vm_or_template/right_sizing.rb | 6 +++--- spec/factories/hardware.rb | 6 ++++++ spec/models/metric_spec.rb | 2 +- 3 files changed, 10 insertions(+), 4 deletions(-) *** Bug 1323326 has been marked as a duplicate of this bug. *** Right sizing recommendation still shows 1 CPU for 4 core machine in 5.6.0.1-beta2.20160413141124_e25ac0e . Look at the attached screenshot. Created attachment 1148870 [details]
Right sizing screenshot
New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/694733a8c0fc99d7e2f8b9e4710e90ae4a7ead5e commit 694733a8c0fc99d7e2f8b9e4710e90ae4a7ead5e Author: Adam Grare <agrare> AuthorDate: Mon Aug 8 16:31:46 2016 -0400 Commit: Adam Grare <agrare> CommitDate: Mon Aug 8 16:31:46 2016 -0400 Display total cpu cores for right sizing https://bugzilla.redhat.com/show_bug.cgi?id=1299809 app/views/vm_common/_right_size.html.haml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) The hotfix is showing recommendation, savings and savings % in terms of cores. However, the UI and right-sizing reports display headers and labels as CPUs. This is very misleading and should be addressed--most probable in another BZ.
On the reports we at least have the option to rename the headers, but on the UI as in attachment 1194407 [details] we are stuck at looking at labels that indicate CPUs and not cores.
Created attachment 1199471 [details]
Correct amount of CPUs
Fixed and verified in 5.7.0.0.20160906172503_12f65cb. Right Size recommendations shows correct amount of cpus.
|