Bug 1300214

Summary:	Failed to build with openshift/golang-ex
Product:	OpenShift Container Platform	Reporter:	Wenjing Zheng <wzheng>
Component:	Templates	Assignee:	Rodolfo Carvalho <rcarvalh>
Status:	CLOSED ERRATA	QA Contact:	XiuJuan Wang <xiuwang>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	3.1.0	CC:	aos-bugs, ipalade, jokerman, mmccomas, tdawson
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-05-12 16:26:58 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Wenjing Zheng 2016-01-20 09:47:20 UTC

Description of problem:
Below error appears when build with openshift/golang-ex:
github.com/openshift/golang-ex/models
github.com/openshift/golang-ex/controllers
# github.com/openshift/golang-ex/controllers
../github.com/openshift/golang-ex/controllers/app.go:79: this.TplNames undefined (type *AppController has no field or method TplNames)
../github.com/openshift/golang-ex/controllers/longpolling.go:38: this.TplNames undefined (type *LongPollingController has no field or method TplNames)
../github.com/openshift/golang-ex/controllers/longpolling.go:45: this.TplNames undefined (type *LongPollingController has no field or method TplNames)
../github.com/openshift/golang-ex/controllers/longpolling.go:66: this.ServeJson undefined (type *LongPollingController has no field or method ServeJson)
../github.com/openshift/golang-ex/controllers/longpolling.go:76: this.ServeJson undefined (type *LongPollingController has no field or method ServeJson)
../github.com/openshift/golang-ex/controllers/websocket.go:41: this.TplNames undefined (type *WebSocketController has no field or method TplNames)
F0120 04:07:53.554946       1 builder.go:185] Error: build error: The command '/bin/sh -c go-wrapper install' returned a non-zero code: 2

Version-Release number of selected component (if applicable):
https://github.com/openshift/golang-ex
openshift v3.1.1.5
kubernetes v1.1.0-origin-1107-g4c8e6f4
etcd 2.1.2

How reproducible:
Always

Steps to Reproduce:
1. Create a project
2. Build with the forked repo
$oc new-app -f  https://raw.githubusercontent.com/openshift/golang-ex/master/openshift/templates/beego.json  -p  SOURCE_REPOSITORY_URL=https://github.com/openshift/golang-ex
 3. Check the build status status
$oc get builds

Actual results:
Build failed with errors in build log.

Expected results:
It should succeed.

Comment 1 Ben Parees 2016-01-20 14:08:32 UTC

Rodolfo or Victor can you take a look at this since you're working on the golang example anyway to add tests?

thanks

Comment 2 Rodolfo Carvalho 2016-01-20 14:24:39 UTC

Taking a look

Comment 3 Rodolfo Carvalho 2016-01-20 14:41:53 UTC

I can reproduce the bug. It was caused by this PR in beego:
https://github.com/astaxie/beego/pull/1540

By looking at the latest commits, looks like they are breaking the API all the time :(

I don't really like using beego in our golang-ex, but, anyway, an old PR I have open will fix the problem by vendoring all dependencies:

https://github.com/openshift/golang-ex/pull/9

Comment 4 Rodolfo Carvalho 2016-01-20 14:49:35 UTC

My PR in golang-ex got merged, the problem should be fixed.

@Wenjing Zheng please check.

Comment 5 Wenjing Zheng 2016-01-21 04:39:40 UTC

Verified with new openshift/golang-ex repo, works correctly. Thanks!

Comment 7 errata-xmlrpc 2016-05-12 16:26:58 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2016:1064