Bug 1300578
| Summary: | Review Request: vim-ack - Run ack search tool from Vim | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Yanis Guenane <yguenane> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | hguemar, mrunge, package-review |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2021-05-31 00:46:01 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 177841, 201449 | ||
|
Description
Yanis Guenane
2016-01-21 08:20:24 UTC
spredzy's scratch build of vim-ack-1.0.9-1.fc23.src.rpm for f24 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12721292 Initially this package was built packaging the 1.0.8 version of this software. This version was lacking a LICENSE file and the license was added in the spec file. A bug had been opened upstream[1] to add this file, which the owner of the project did and released a 1.0.9 version with the LICENSE included. Those are the links for the 1.0.9 (latest): Spec URL: https://pub.yanisguenane.fr/fedora/packaging/vim-ack/vim-ack.spec SRPM URL: https://pub.yanisguenane.fr/fedora/packaging/vim-ack/vim-ack-1.0.9-1.fc23.src.rpm Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=12721292 Those are the links for the 1.0.8 to compare: Spec URL: https://pub.yanisguenane.fr/fedora/packaging/vim-ack/vim-ack_1.0.8.spec SRPM URL: https://pub.yanisguenane.fr/fedora/packaging/vim-ack/vim-ack-1.0.8-1.fc23.src.rpm Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=12631325 [1] https://github.com/mileszs/ack.vim/issues/172 One major issue, your package owns directories owned by vim-filesystem, just name files/directories inside these directories instead:
%{vimfiles_root}/plugin/
%{vimfiles_root}/autoload/ %{vimfiles_root}/ftplugin/
According guidelines, your specfile should be named vim-ack.spec. It's minor issue, but it breaks automated reviewing tools.
spredzy's scratch build of vim-ack-1.0.9-1.fc23.src.rpm for f24 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=13114318 @Haïkel Thank you for pointing #1. It has been fixed and a new spec file has been uploaded at the same place. For #2, I am reposting the link here in order to be caugh by fedora-review Spec URL: https://pub.yanisguenane.fr/fedora/packaging/vim-ack/vim-ack.spec SRPM URL: https://pub.yanisguenane.fr/fedora/packaging/vim-ack/vim-ack-1.0.9-1.fc23.src.rpm This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time. We're sorry it is taking so long. If you're still interested in packaging this software into Fedora repositories, please respond to this comment clearing the NEEDINFO flag. You may want to update the specfile and the src.rpm to the latest version available and to propose a review swap on Fedora devel mailing list to increase chances to have your package reviewed. If this is your first package and you need a sponsor, you may want to post some informal reviews. Read more at https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group. Without any reply, this request will shortly be considered abandoned and will be closed. Thank you for your patience. This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it. |