Bug 1301227

Summary: Tiering should break out of iterating query file once cycle time completes.
Product: [Community] GlusterFS Reporter: Dan Lambright <dlambrig>
Component: tieringAssignee: Dan Lambright <dlambrig>
Status: CLOSED CURRENTRELEASE QA Contact: bugs <bugs>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: mainlineCC: bugs
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: glusterfs-3.8rc2 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1318203 (view as bug list) Environment:
Last Closed: 2016-06-16 13:55:37 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1318203    

Description Dan Lambright 2016-01-22 22:31:26 UTC
Description of problem:

When iterating the query file during migration, should break out of loop once cycle time completes.

Version-Release number of selected component (if applicable):

N/A

How reproducible:

always

Steps to Reproduce:
1. Set demotion cycle time to 120 seconds.
2. Create many large files.
2. Wait for them to be demoted.

Actual results:

All the files will be demoted, this may take longer than 120 seconds. 

Expected results:

As many files as can be moved in 120 seconds shall be migrated.

Additional info:

Comment 1 Vijay Bellur 2016-02-02 22:07:06 UTC
REVIEW: http://review.gluster.org/13284 (cluster/tier: break out of iterating query file once cycle time ends) posted (#2) for review on master by Dan Lambright (dlambrig)

Comment 2 Vijay Bellur 2016-02-03 16:15:26 UTC
COMMIT: http://review.gluster.org/13284 committed in master by Dan Lambright (dlambrig) 
------
commit 58a91f36f639de21f6e77d1f43f5eb091ae96fb0
Author: Dan Lambright <dlambrig>
Date:   Fri Jan 22 17:31:48 2016 -0500

    cluster/tier: break out of iterating query file once cycle time ends
    
    When iterating the query file during migration, tiering should
    break out of the loop once cycle time completes. Otherwise it
    may be possible to stay in the loop for a long time. If that
    happens updates to files will become stale and have not impact
    migration.
    
    Change-Id: Ib60cf74bc84e8646e6a0da21ff04954b1b83c414
    BUG: 1301227
    Signed-off-by: Dan Lambright <dlambrig>
    Reviewed-on: http://review.gluster.org/13284
    Smoke: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.com>

Comment 3 Mike McCune 2016-03-28 22:28:36 UTC
This bug was accidentally moved from POST to MODIFIED via an error in automation, please see mmccune with any questions

Comment 4 Niels de Vos 2016-06-16 13:55:37 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user