Bug 1301285

Summary: Review Request: perl-Mock-Sub - Mock package, object and standard subroutines, with unit testing in mind
Product: [Fedora] Fedora Reporter: Denis Fateyev <denis>
Component: Package ReviewAssignee: Jitka Plesnikova <jplesnik>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: jplesnik, package-review, perl-devel
Target Milestone: ---Flags: jplesnik: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-02-02 19:19:55 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1285518    

Description Denis Fateyev 2016-01-23 15:28:53 UTC
Spec URL: http://www.fateyev.com/RPMS/Fedora22/perl-Mock-Sub.spec
SRPM URL: http://www.fateyev.com/RPMS/Fedora22/perl-Mock-Sub-1.05-1.fc24.src.rpm
Description: Easy to use and very lightweight module for mocking out sub calls. Very useful for testing areas of your own modules where getting coverage may be difficult due to nothing to test against, and/or to reduce test run time by eliminating the need to call subs that you really don't want or need to test.
Fedora Account System Username: dfateyev

Koji scratch builds:
https://koji.fedoraproject.org/koji/taskinfo?taskID=12663284 (Rawhide)
https://koji.fedoraproject.org/koji/taskinfo?taskID=12663282 (EPEL 6)

Comment 1 Upstream Release Monitoring 2016-01-24 16:51:00 UTC
dfateyev's scratch build of perl-Mock-Sub-1.06-1.fc23.denf.src.rpm for dist-6E-epel completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12668867

Comment 2 Denis Fateyev 2016-01-24 17:03:06 UTC
The author has recently updated module to 1.06 version.

Spec URL: http://www.fateyev.com/RPMS/Fedora22/perl-Mock-Sub.spec
SRPM URL: http://www.fateyev.com/RPMS/Fedora22/perl-Mock-Sub-1.06-1.fc24.src.rpm

Comment 3 Jitka Plesnikova 2016-01-25 12:05:50 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Mock-Sub-1.06-1.fc24.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.22.1)
      1 perl(:VERSION) >= 5.6.0
      1 perl(Carp)
      1 perl(Mock::Sub::Child)
      1 perl(Scalar::Util)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1

Binary requires are Ok.

$ rpm -qp --provides perl-Mock-Sub-1.06-1.fc24.noarch.rpm | sort | uniq -c
      1 perl(Mock::Sub) = 1.06
      1 perl(Mock::Sub::Child) = 1.06
      1 perl-Mock-Sub = 1.06-1.fc24

Binary provides are Ok.

$ rpmlint perl-Mock-Sub*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

Rpmlint is ok

The package looks good.
Approved

Comment 4 Gwyn Ciesla 2016-01-25 14:13:18 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/perl-Mock-Sub

Comment 5 Fedora Update System 2016-01-25 18:44:04 UTC
perl-Mock-Sub-1.06-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-d8f26692b9

Comment 6 Fedora Update System 2016-01-25 18:44:04 UTC
perl-Mock-Sub-1.06-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-f3c1ee16bc

Comment 7 Fedora Update System 2016-01-25 18:44:07 UTC
perl-Mock-Sub-1.06-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-f3c1ee16bc

Comment 8 Fedora Update System 2016-01-25 18:44:11 UTC
perl-Mock-Sub-1.06-1.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-b5d6dd8c04

Comment 9 Fedora Update System 2016-01-25 18:44:12 UTC
perl-Mock-Sub-1.06-1.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-1b2ddf0aab

Comment 10 Fedora Update System 2016-01-26 03:49:06 UTC
perl-Mock-Sub-1.06-1.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-1b2ddf0aab

Comment 11 Fedora Update System 2016-01-26 03:53:01 UTC
perl-Mock-Sub-1.06-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-f3c1ee16bc

Comment 12 Fedora Update System 2016-01-26 04:21:37 UTC
perl-Mock-Sub-1.06-1.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-b5d6dd8c04

Comment 13 Fedora Update System 2016-01-26 04:27:17 UTC
perl-Mock-Sub-1.06-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-d8f26692b9

Comment 14 Fedora Update System 2016-02-02 19:19:53 UTC
perl-Mock-Sub-1.06-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

Comment 15 Fedora Update System 2016-02-02 23:52:37 UTC
perl-Mock-Sub-1.06-1.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.

Comment 16 Fedora Update System 2016-02-10 11:03:16 UTC
perl-Mock-Sub-1.06-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.

Comment 17 Fedora Update System 2016-02-10 11:13:42 UTC
perl-Mock-Sub-1.06-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.