| Summary: | Switch to systemd unit files | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Kevin Fenzi <kevin> | ||||
| Component: | sigul | Assignee: | Miloslav Trmač <mitr> | ||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | rawhide | CC: | mitr | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2016-01-25 17:50:34 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Attachments: |
|
||||||
Thanks for the patch.
AFAICS those units couldn’t work:
* Starting services as the sigul user means they don't have enough privileges to open the log file, or create the pid file (nor to implement the unix-{user,group} directives from the config files).
* Type=simple along with -d means the service terminates as soon as the parent launches the daemon child.
I have now built sigul-0.102-2.fc24 with units that seem to work for me, though testing would be appreciated.
(systemctl stop takes 90 seconds to time out for each service, mostly due to #707382; but eventually systemd does terminate the daemons. The default timeout could very likely be tuned further, but this is good enough as a minimal conversion.)
Yeah, I meant to test, but ran out of time. ;) Sorry about that and thanks for fixing things up. |
Created attachment 1117485 [details] Convert sigul to using systemd units Soon FESCo has decided to drop all packages that still use sysvinit scripts. I've attached a patch that moves sigul to use systemd units instead of sysvinit scripts. Consider applying, or if you prefer I can go ahead and apply and build.