Bug 1301419
| Summary: | rubygem-sinatra-1.4.7 is available | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Upstream Release Monitoring <upstream-release-monitoring> | ||||||
| Component: | rubygem-sinatra | Assignee: | Jun Aruga <jaruga> | ||||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | unspecified | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | rawhide | CC: | dcleal, jaruga, mfojtik, strzibny, vondruch | ||||||
| Target Milestone: | --- | Keywords: | FutureFeature, Triaged | ||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | rubygem-sinatra-1.4.7-1.fc25 | Doc Type: | Enhancement | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2016-08-08 15:15:33 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 1344101 | ||||||||
| Attachments: |
|
||||||||
|
Description
Upstream Release Monitoring
2016-01-25 00:17:58 UTC
Created attachment 1117734 [details]
[patch] Update to 1.4.7 (#1301419)
Scratch build failed http://koji.fedoraproject.org/koji/taskinfo?taskID=12671947 I will take this! Created attachment 1186535 [details]
Update to 1.4.7. Fix broken dependency.
Hi, I updated to latest version 1.4.7.
And I fixed broken dependency. The dependency was broken depended library "rubygem-rack" was updated to 2.0.1 for both master(rawhide) and f25.
If you update this patch to master and f25, you can fix it.
or I can push it by myself.
Could you review my patch?
Thanks.
You must be receiving below mail.
```
Broken dependencies: rubygem-sinatra
rubygem-sinatra has broken dependencies in the rawhide tree:
On x86_64:
1:rubygem-sinatra-1.4.6-3.fc24.noarch requires rubygem(rack) < 0:2
On i386:
1:rubygem-sinatra-1.4.6-3.fc24.noarch requires rubygem(rack) < 0:2
On armhfp:
1:rubygem-sinatra-1.4.6-3.fc24.noarch requires rubygem(rack) < 0:2
Please resolve this as soon as possible.
```
Is there some reason why you merge the patches into single file, instead of applying them one by one? I think that the later would be more readable ... (In reply to Vít Ondruch from comment #6) > Is there some reason why you merge the patches into single file, instead of > applying them one by one? I think that the later would be more readable ... Yes, I have a reason to unify these commits to single patch file. ``` +# Patch for Rack 2.x. +# https://github.com/sinatra/sinatra/commit/6aea9f8 +# https://github.com/sinatra/sinatra/commit/fad3619 +# https://github.com/sinatra/sinatra/commit/1a9642b +# https://github.com/sinatra/sinatra/commit/1dfae3d +Patch0: rubygem-sinatra-1.4.7-fix-for-rack-2.patch ``` I needed to fix conflict manually to create a patch for 1st commit (6aea9f8). Then I created 2nd, 3rd and 4th patches based on 1st patched source code. And all of these 4 commits is going to be included to next version's gem. So, I thought a patch is better than 4 separated patch. That is the reason. Ref. Below is my working branch for that. Latest 4 commits. https://github.com/junaruga/sinatra/commits/feature/fix-for-rack2-based-on-v1.4.7 However I can also create 4 patches for you, if you like. How do you think? Do you prefer 4 patches than single patch? Thanks for explanation. It is suboptimal, but since it is hopefully just temporary measure, lets live with that => I build the updated package in F25+ |