Bug 1301440

Summary:	[fork][userinterface_public_455]It's better to show error notification when click save button if there is error on bc edit page
Product:	OKD	Reporter:	Yadan Pei <yapei>
Component:	Management Console	Assignee:	Jakub Hadvig <jhadvig>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Yadan Pei <yapei>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	3.x	CC:	aos-bugs, mmccomas, spadgett
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-05-12 17:14:43 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Yadan Pei 2016-01-25 03:07:04 UTC

Description of problem:
when there is configuration error on bc edit page console didn't popup error notification nor redirect to bc browse page when click "Save" button, user must click "Cancel" button to return bc browse page and see the error. It's better to give error notification and redirection on clicking "Save" button if error occurs during edit.

Version-Release number of selected component (if applicable):
fork_ami_openshift3_userinterface_public_455_187

How reproducible:
Always

Steps to Reproduce:
1.Create buildconfig
2.Access buildconfig edit page
3. Select "Automatically build a new image when the builder image changes" but leave "Build From" as "None" in Image Configuration
4. Click save

Actual results:
4. Click on save button stay on edit page and no useful info printed

Expected results:
4. Click on save button should redirect to bc browse page and give error notification


Additional info:

Comment 1 Samuel Padgett 2016-01-25 13:11:18 UTC

I suggest we stay on the edit page when there are errors so the user can fix the problem and doesn't lose their edits. We need to show an error message, though.

Comment 2 Yadan Pei 2016-01-26 02:03:00 UTC

agree, that will be more reasonable.

Comment 3 Yadan Pei 2016-01-26 02:05:03 UTC

summary changed to clarify the issue

Comment 4 Yadan Pei 2016-02-05 07:19:09 UTC

checked on latest origin devenv-rhel7_3335

1) when bc is changed via CLI before do any update on web console, click "Save" button will popup error notification indicating user should apply change against latest version
2) when bc is deleted and bc edit page still opens, there will be error message ob edit page indicating bc is deleted, user are not allowed to change anything for bc

it is reasonable and works as expected, could verify it once it is changed to ON_QA