Bug 1301607

Summary: exception silently raised at registration against satellite 6.1
Product: Red Hat CloudForms Management Engine Reporter: Felix Dewaleyne <fdewaley>
Component: ApplianceAssignee: Nick Carboni <ncarboni>
Status: CLOSED ERRATA QA Contact: Jan Krocil <jkrocil>
Severity: medium Docs Contact:
Priority: high    
Version: 5.4.0CC: abellott, cpelland, dajohnso, fdewaley, grobinson, jhardy, jprause, ldixon, mfeifer, ncarboni, obarenbo, simaishi, ssainkar, vcojot
Target Milestone: GAKeywords: ZStream
Target Release: 5.6.0   
Hardware: All   
OS: All   
Whiteboard: foreman
Fixed In Version: 5.6.0.4 Doc Type: Bug Fix
Doc Text:
Previously, Satellite 6 subscription organization handling was preventing correctly saving the organization name,which prevented anyone from subscribing to updates from Satellite 6. As a result, an exception was silently raised at registration against Satellite 6.1 With this patch, a new form key which stores the organization display name was created which has now resolved the issue.
Story Points: ---
Clone Of:
: 1326460 1326463 (view as bug list) Environment:
Last Closed: 2016-06-29 15:32:58 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1326460, 1326463    
Attachments:
Description Flags
reproducer_evm.log
none
reproducer_full_evm.log none

Description Felix Dewaleyne 2016-01-25 13:58:02 UTC
Created attachment 1118022 [details]
reproducer_evm.log

Description of problem:
during registration against a satellite 6.1, any error due to the company name are not raised in the web interface

Version-Release number of selected component (if applicable):
5.4.4.2

How reproducible:
all the time

Steps to Reproduce:
1. deploy a satellite 6.1 using katello and sync in the cfme channels
2. deploy cloudforms 3.2 in its latest version in the rhev environemnt
3. configure the appliance to register to the satellite 6.1

Actual results:
the registration silently fails

Expected results:
the registration status is updated with the error or passes

Additional info:
trace generated in reproducer : see attachment

satellite 6.1 deployed using 

katello-installer --foreman-admin-username satadmin --foreman-admin-password smartvm --foreman-initial-location "Farnborough" --foreman-initial-organization "RedHat_GSS" -v

Comment 1 Felix Dewaleyne 2016-01-25 14:00:37 UTC
Created attachment 1118036 [details]
reproducer_full_evm.log

attaching the full log of the appliance that ran the registration

Comment 4 Felix Dewaleyne 2016-01-25 18:09:52 UTC
reproduced against cloudforms 4.0 as well :

[----] I, [2016-01-25T13:04:15.458291 #11838:f8f994]  INFO -- : MIQ(MiqPriorityWorker::Runner#get_message_via_drb) Message id: [1000000000190], MiqWorker id: [1000000000004], Zone: [default], Role: [], Server: [], Ident: [generic], Targe
t id: [], Instance id: [], Task id: [], Command: [RegistrationSystem.verify_credentials], Timeout: [600], Priority: [20], State: [dequeue], Deliver On: [], Data: [], Args: [{:task_id=>1000000000005}], Dequeued in: [2.694876014] seconds
[----] I, [2016-01-25T13:04:15.458471 #11838:f8f994]  INFO -- : MIQ(MiqQueue#deliver) Message id: [1000000000190], Delivering...
[----] I, [2016-01-25T13:04:16.017877 #11834:5c7998]  INFO -- : MIQ(MiqGenericWorker::Runner#get_message_via_drb) Message id: [1000000000191], MiqWorker id: [1000000000003], Zone: [default], Role: [], Server: [2c2a5c08-c38b-11e5-bb8a-001
a4a21300c], Ident: [generic], Target id: [], Instance id: [1000000000001], Task id: [], Command: [MiqServer.update_registration_status], Timeout: [600], Priority: [100], State: [dequeue], Deliver On: [], Data: [], Args: [], Dequeued in:
[2.048813414] seconds
[----] I, [2016-01-25T13:04:16.018120 #11834:5c7998]  INFO -- : MIQ(MiqQueue#deliver) Message id: [1000000000191], Delivering...
[----] I, [2016-01-25T13:04:16.296936 #11838:f8f994]  INFO -- : MIQ(MiqQueue#delivered) Message id: [1000000000190], State: [ok], Delivered in [0.838400406] seconds
[----] I, [2016-01-25T13:04:16.299340 #11838:f8f994]  INFO -- : MIQ(MiqQueue#m_callback) Message id: [1000000000190], Invoking Callback with args: ["Finished", "ok", "Message delivered successfully", "false"]
[----] I, [2016-01-25T13:04:16.376119 #11838:f8f994]  INFO -- : MIQ(MiqTask#update_status) Task: [1000000000005] [Finished] [Ok] [Task completed successfully]
[----] I, [2016-01-25T13:04:16.662561 #11834:5c7998]  INFO -- : MIQ(MiqServer#register) Registering appliance...
[----] W, [2016-01-25T13:04:16.857857 #11831:8d598c]  WARN -- : MIQ(MiqDatabase#authentication_check_no_validation) type: [:registration] for [1000000000001] [vmdb_production] Validation failed: invalid, Unknown reason
[----] W, [2016-01-25T13:04:16.858438 #11831:8d598c]  WARN -- : MIQ(AuthUseridPassword#validation_failed) [MiqDatabase] [1000000000001], previously valid on: , previous status: []
[----] I, [2016-01-25T13:04:16.871800 #11831:8d598c]  INFO -- : MIQ(MiqQueue#delivered) Message id: [1000000000188], State: [ok], Delivered in [4.285355773] seconds
[----] E, [2016-01-25T13:04:20.047201 #11834:5c7998] ERROR -- : AwesomeSpawn: subscription-manager register exit code: 70
[----] E, [2016-01-25T13:04:20.047472 #11834:5c7998] ERROR -- : AwesomeSpawn: Couldn't find Organization '["RedHat GSS", "RedHat_GSS"]'.

[----] E, [2016-01-25T13:04:20.048196 #11834:5c7998] ERROR -- : MIQ(MiqQueue#deliver) Message id: [1000000000191], Error: [subscription-manager register exit code: 70]
[----] E, [2016-01-25T13:04:20.048449 #11834:5c7998] ERROR -- : [AwesomeSpawn::CommandResultError]: subscription-manager register exit code: 70  Method:[rescue in deliver]
[----] E, [2016-01-25T13:04:20.048609 #11834:5c7998] ERROR -- : /opt/rh/cfme-gemset/gems/awesome_spawn-1.3.0/lib/awesome_spawn.rb:102:in `run!'
/opt/rh/cfme-gemset/gems/linux_admin-0.12.1/lib/linux_admin/common.rb:24:in `run!'
/opt/rh/cfme-gemset/gems/linux_admin-0.12.1/lib/linux_admin/registration_system/subscription_manager.rb:6:in `run!'
/opt/rh/cfme-gemset/gems/linux_admin-0.12.1/lib/linux_admin/registration_system/subscription_manager.rb:52:in `register'
/opt/rh/cfme-gemset/gems/linux_admin-0.12.1/lib/linux_admin/registration_system.rb:15:in `method_missing'
/var/www/miq/vmdb/app/models/miq_server/update_management.rb:84:in `register'
/var/www/miq/vmdb/app/models/miq_server/update_management.rb:59:in `attempt_registration'
/var/www/miq/vmdb/app/models/miq_server/update_management.rb:53:in `update_registration_status'
/var/www/miq/vmdb/app/models/miq_queue.rb:345:in `block in deliver'
/opt/rh/rh-ruby22/root/usr/share/ruby/timeout.rb:89:in `block in timeout'
/opt/rh/rh-ruby22/root/usr/share/ruby/timeout.rb:34:in `block in catch'
/opt/rh/rh-ruby22/root/usr/share/ruby/timeout.rb:34:in `catch'
/opt/rh/rh-ruby22/root/usr/share/ruby/timeout.rb:34:in `catch'
/opt/rh/rh-ruby22/root/usr/share/ruby/timeout.rb:104:in `timeout'
/var/www/miq/vmdb/app/models/miq_queue.rb:341:in `deliver'
/var/www/miq/vmdb/app/models/miq_queue_worker_base/runner.rb:106:in `deliver_queue_message'
/var/www/miq/vmdb/app/models/miq_queue_worker_base/runner.rb:134:in `deliver_message'
/var/www/miq/vmdb/app/models/miq_queue_worker_base/runner.rb:151:in `block in do_work'
/var/www/miq/vmdb/app/models/miq_queue_worker_base/runner.rb:145:in `loop'
/var/www/miq/vmdb/app/models/miq_queue_worker_base/runner.rb:145:in `do_work'
/var/www/miq/vmdb/app/models/miq_worker/runner.rb:334:in `block in do_work_loop'
/var/www/miq/vmdb/app/models/miq_worker/runner.rb:331:in `loop'
/var/www/miq/vmdb/app/models/miq_worker/runner.rb:331:in `do_work_loop'
/var/www/miq/vmdb/app/models/miq_worker/runner.rb:153:in `run'
/var/www/miq/vmdb/app/models/miq_worker/runner.rb:128:in `start'
/var/www/miq/vmdb/app/models/miq_worker/runner.rb:29:in `start_worker'
/var/www/miq/vmdb/lib/workers/bin/worker.rb:2:in `<top (required)>'
/opt/rh/cfme-gemset/gems/railties-4.2.5/lib/rails/commands/runner.rb:60:in `load'
/opt/rh/cfme-gemset/gems/railties-4.2.5/lib/rails/commands/runner.rb:60:in `<top (required)>'
/opt/rh/cfme-gemset/gems/railties-4.2.5/lib/rails/commands/commands_tasks.rb:123:in `require'
/opt/rh/cfme-gemset/gems/railties-4.2.5/lib/rails/commands/commands_tasks.rb:123:in `require_command!'
/opt/rh/cfme-gemset/gems/railties-4.2.5/lib/rails/commands/commands_tasks.rb:90:in `runner'
/opt/rh/cfme-gemset/gems/railties-4.2.5/lib/rails/commands/commands_tasks.rb:39:in `run_command!'
/opt/rh/cfme-gemset/gems/railties-4.2.5/lib/rails/commands.rb:17:in `<top (required)>'
/var/www/miq/vmdb/bin/rails:4:in `require'
/var/www/miq/vmdb/bin/rails:4:in `<main>'

Comment 5 Felix Dewaleyne 2016-02-01 10:18:48 UTC
versions of subscription-manager used in reproducers :

subscription-manager-1.15.9-15.el7.x86_64
subscription-manager-1.14.10-1.el6.x86_64

Comment 6 Shveta 2016-02-01 21:31:25 UTC
Assigning to add test case

Comment 11 Nick Carboni 2016-04-12 13:12:46 UTC
https://github.com/ManageIQ/manageiq/pull/7893

Comment 15 CFME Bot 2016-04-13 20:36:02 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/225111684107b274516da83267a59587ff958518

commit 225111684107b274516da83267a59587ff958518
Author:     Nick Carboni <ncarboni>
AuthorDate: Mon Apr 11 17:51:11 2016 -0400
Commit:     Nick Carboni <ncarboni>
CommitDate: Mon Apr 11 18:14:00 2016 -0400

    Fix Sat6 subscription organization handling
    
    This was preventing correctly saving the organization name,
    which prevented any one from subscribing to updates from Sat6.
    
    Created a new form key which stores the organization display name.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1301607

 app/controllers/ops_controller/settings/common.rb |  5 ++-
 app/controllers/ops_controller/settings/rhn.rb    | 40 +++++++++++++----------
 app/views/ops/_settings_rhn_edit_tab.html.haml    |  4 +--
 3 files changed, 26 insertions(+), 23 deletions(-)

Comment 20 errata-xmlrpc 2016-06-29 15:32:58 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2016:1348