Bug 1302584

Summary: CapacityFilter in capacity_filter.py does not calculate correctly
Product: Red Hat OpenStack Reporter: Shinobu KINJO <skinjo>
Component: openstack-cinderAssignee: Eric Harney <eharney>
Status: CLOSED DUPLICATE QA Contact: nlevinki <nlevinki>
Severity: high Docs Contact:
Priority: medium    
Version: 6.0 (Juno)CC: eharney, sgotliv, yeylon
Target Milestone: ---   
Target Release: 8.0 (Liberty)   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-01-28 11:13:28 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Shinobu KINJO 2016-01-28 08:33:08 UTC
Description of problem:

In order to calculate free space correctly, free needs to be based on free_space value.
Is it possible to backport CapacityFilter class in [2] to Juno based OSP?


  [1] openstack-cinder-2014.2.4-2.el7ost.noarch
   29 class CapacityFilter(filters.BaseHostFilter):
   30     """CapacityFilter filters based on volume host's capacity utilization."""
   31 
   32     def host_passes(self, host_state, filter_properties):
     ...
   55         reserved = float(host_state.reserved_percentage) / 100
   56         free = math.floor(free_space * (1 - reserved))


  [2] openstack-cinder-2015.1.2-5.el7ost.noarch
   31 class CapacityFilter(filters.BaseHostFilter):
   32     """CapacityFilter filters based on volume host's capacity utilization."""
   33 
   34     def host_passes(self, host_state, filter_properties):
     ...
   50         free_space = host_state.free_capacity_gb
   51         total_space = host_state.total_capacity_gb
   52         reserved = float(host_state.reserved_percentage) / 100
     ...
   78         free = free_space - math.floor(total * reserved)

Rgds,
Shinobu

Version-Release number of selected component (if applicable):

  [1] openstack-cinder-2014.2.4-2.el7ost.noarch.rpm

How reproducible:

Steps to Reproduce:
1.
2.
3.

Actual results:

Expected results:

Additional info:

Comment 2 Sergey Gotliv 2016-01-28 11:13:28 UTC
I guess this is a dup of BZ#1302586.

*** This bug has been marked as a duplicate of bug 1302586 ***