Bug 1303023
Summary: | missing result="" attribute on <result/> element in job results XML | ||
---|---|---|---|
Product: | [Retired] Beaker | Reporter: | Ales Zelinka <azelinka> |
Component: | reports | Assignee: | Dan Callaghan <dcallagh> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | matt jia <mjia> |
Severity: | urgent | Docs Contact: | |
Priority: | urgent | ||
Version: | 22 | CC: | dcallagh, fweimer, mfrodl, mjia, rjoost |
Target Milestone: | 22.1 | Keywords: | Patch, Regression, TestBlocker |
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2016-02-01 04:30:32 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 1303004 |
So it turns out our test coverage for job results XML is not very thorough, which in hindsight is obviously quite a serious problem. However I have compared the results XML output from release-21 branch vs. release-22 branch and this missing result="" attribute is the only issue I can see. I am going to add some more complete test cases for the job results XML too but I don't want to hold up this fix for those. (In reply to Dan Callaghan from comment #3) > I am going to add some more complete test cases for the job results XML too > but I don't want to hold up this fix for those. http://gerrit.beaker-project.org/4649 Steps to verify: 1. look at one completed job results XML. 2. It contains the <result> element. (In reply to matt jia from comment #6) > Steps to verify: > > 1. look at one completed job results XML. > > 2. It contains the <result> element. To be more specially, the missing result attribute has been added back to the <result> element. Beaker 22.1 has been released. |
Description of problem: result element no longer has result attribute. We rely on this in out tooling (tcms-results). This change breaks all beaker regression testing. Details by xzhou: > One attribute "result" has gone. > > -<result id="184817448" path="/start" result="Pass" score="0.00">Install Started</result> > +<result id="184817448" path="/start" score="0.00">Install Started</result> Version-Release number of selected component (if applicable): 22.0