Bug 1303284
| Summary: | puppet-firewalld 0.2.2 is incompatible with puppet 4.2.1 | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ed Marshall <esm> |
| Component: | puppet-firewalld | Assignee: | Jiri Popelka <jpopelka> |
| Status: | CLOSED EOL | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 23 | CC: | jpopelka |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-12-20 18:18:36 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
This message is a reminder that Fedora 23 is nearing its end of life. Approximately 4 (four) weeks from now Fedora will stop maintaining and issuing updates for Fedora 23. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '23'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 23 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. Fedora 23 changed to end-of-life (EOL) status on 2016-12-20. Fedora 23 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed. |
Two problems relating to compatibility issues between puppet and puppet-firewalld: puppet-4.2.1-2.fc23.noarch puppet-firewalld-0.2.2-2.fc23.noarch 1. puppet-firewalld has an empty if block in zone.pp, which results in this error on the version of puppet included in Fedora: Error: This 'if' statement has no effect. A value-producing expression without other effect may only be placed last in a block/sequence at /usr/share/puppet/modules/firewalld/manifests/zone.pp:161:2 on node <nodename> A quick fix is to simply remove this section at line 161 of /usr/share/puppet/modules/firewalld/manifests/zone.pp: if "${rich_rules}" != [] { # TODO: assert there's one (and only one of) # {service, port, protocol, icmp_block, masquerade, forward_port} # (So far I have no idea how to do that) } (Which appears to be what has been done on upstream master.) 2. manifests/configuration.pp and templates/firewalld.conf.erb have a variable named $IPv6_rpfilter, with newer versions of puppet reject with the following error: Error: Illegal parameter name. The given name 'IPv6_rpfilter' does not conform to the naming rule /^[a-z_]\w*$/ at /usr/share/puppet/modules/firewalld/manifests/configuration.pp:56:2 on node <nodename> Lowercasing the variable in both the manifest and the template corrects the problem; this appears to be what was done in upstream master as well.