| Summary: | [RFE][HostQoS] - modify hostQoS of existing networks instead of reconfiguring the network | ||
|---|---|---|---|
| Product: | [oVirt] vdsm | Reporter: | Michael Burman <mburman> |
| Component: | Core | Assignee: | Edward Haas <edwardh> |
| Status: | CLOSED WONTFIX | QA Contact: | Michael Burman <mburman> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 4.17.19 | CC: | bugs, danken, myakove, ylavi |
| Target Milestone: | --- | Keywords: | FutureFeature |
| Target Release: | --- | Flags: | ylavi:
ovirt-future?
ylavi: planning_ack? ylavi: devel_ack? ylavi: testing_ack? |
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-06-06 07:45:23 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | Network | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
Vdsm's recognition that initiscript has not configured hostQoS on the network is *not* a bug. It is the right thing for Vdsm to do, since initscripts has no facilities for setting ovirt-style hostQoS. The only issue here is that Vdsm should simply add the missing hostQoS, and not drop the network and re-add it. Moving from 4.0 alpha to 4.0 beta since 4.0 alpha has been already released and bug is not ON_QA. oVirt 4.0 beta has been released, moving to RC milestone. oVirt 4.0 beta has been released, moving to RC milestone. This is in fact a RFE that can handle other on-the-fly settings and not be limited by QoS config. I suggest we revisit this feature as part of the new suggested VDSM networking setup flow. Closing old RFEs, please reopen if still needed. Patches are always welcomed. |
Description of problem: [HostQoS] - Vdsm recognizes a change in hostQoS every reboot. ifcfg doesn't persist hostQoS at all and initscripts can't handle it during the boot process. Because of that vdsm will recognize a change every reboot for network that was configured with host QoS and will touch it during the reboots. supervdsm.log --> restore-net::INFO::2016-01-31 12:58:05,486::vdsm-restore-net-config::265::root::(_find_changed_or_missing) qosvlan2 is different or missing from persistent configuration. current: {'vlan': '168', 'nic': 'enp12s0f1 ', 'dhcpv6': False, 'mtu': '1500', 'bootproto': 'none', 'stp': False, 'bridged': True, 'defaultRoute': False}, persisted: {'dhcpv6': False, u'bridged': True, u'nic': u'enp12s0f1', u'vlan': '168', u'mtu': '1500', ' bootproto': 'none', 'stp': False, u'hostQos': {u'out': {u'rt': {u'm2': 400000000}, u'ul': {u'm2': 500000000}, u'ls': {u'm2': 70}}}, 'defaultRoute': False} restore-net::INFO::2016-01-31 13:10:33,953::vdsm-restore-net-config::261::root::(_find_changed_or_missing) n3 is different or missing from persistent configuration. current: {'nic': 'ens1f1', 'dhcpv6': False, 'mtu': '1500', 'bootproto': 'none', 'stp': False, 'bridged': True, 'defaultRoute': False}, persisted: {u'hostQos': {u'out': {u'rt': {u'm2': 400000000}, u'ul': {u'm2': 500000000}, u'ls': {u'm2': 60}}}, u'nic': u'ens1f1', 'dhcpv6': False, u'mtu': '1500', 'bootproto': 'none', 'stp': False, u'bridged': True, 'defaultRoute': False} Version-Release number of selected component (if applicable): vdsm-4.17.19-0.el7ev.noarch 3.6.3-0.1.el6 How reproducible: 100 Steps to Reproduce: 1. Attach network with hostQoS configured to host via Setup Networks 2. Reboot server Actual results: vdsm recognize a change in hostQoS and touch the network during the boot Expected results: vdsm shouldn't recognize a change between the current and persistent on network with hostQoS configured. vdsm should handle this.