Bug 1303590

Summary: Never repack .jar files
Product: Red Hat Enterprise Virtualization Manager Reporter: Juan Hernández <juan.hernandez>
Component: ovirt-engineAssignee: Juan Hernández <juan.hernandez>
Status: CLOSED CURRENTRELEASE QA Contact: Juan Hernández <juan.hernandez>
Severity: low Docs Contact:
Priority: low    
Version: 3.6.3CC: eedri, gklein, juan.hernandez, lsurette, rbalakri, Rhev-m-bugs, sbonazzo, srevivo, ykaul, ylavi
Target Milestone: ovirt-3.6.5Keywords: CodeChange, ZStream
Target Release: 3.6.3   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-04-21 14:44:14 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Integration RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Juan Hernández 2016-02-01 11:45:43 UTC
Currently the build process of the engine disables repacking of .jar files only for quick builds, intended for tests. It does so setting the "__jar_repack" global macro to 0:

  %global __jar_repack 0

But this repackaging isn't really useful for us, as repackging is intended for packages that contain multilib .jar files, as described here:

  https://www.redhat.com/archives/fedora-devel-java-list/2008-September/msg00041.html

As repackaging takes a long time, it would be better for us to always disable it, as already done upstream in the master branch:

  packaging: Never repack .jar files
  https://gerrit.ovirt.org/52917

Comment 1 Yaniv Lavi 2016-02-03 08:14:57 UTC
Please test this on brew prior to merging this change to stable branches.

Comment 4 Sandro Bonazzola 2016-03-22 15:52:30 UTC
As far as I can tell, it's already in 3.6.4 code. Maybe even in 3.6.3.

Comment 5 Gil Klein 2016-03-23 08:35:33 UTC
(In reply to Sandro Bonazzola from comment #4)
> As far as I can tell, it's already in 3.6.4 code. Maybe even in 3.6.3.
Moving to 3.6.5 for verification as we won't have time to verify it for 3.6.4

Comment 6 Pavel Stehlik 2016-04-01 07:37:37 UTC
Nothing for QE, thus acked & reassigned contact.

Comment 7 Gil Klein 2016-04-11 07:39:58 UTC
Juan, is there anything QE can do to test this BZ?

Comment 8 Juan Hernández 2016-04-11 08:11:33 UTC
No Gil, nothing other than making sure that the engine works as usual.

Comment 9 Gil Klein 2016-04-14 07:36:35 UTC
Moving to verified based on comment #8.