| Summary: | NetworkManager Bridged Team MTU Fails to Set | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | Trae Santiago <tsantiago> |
| Component: | NetworkManager | Assignee: | Beniamino Galvani <bgalvani> |
| Status: | CLOSED ERRATA | QA Contact: | Desktop QE <desktop-qa-list> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 7.2 | CC: | aloughla, bgalvani, fgiudici, lrintel, mabrown, rkhan, thaller, vbenes |
| Target Milestone: | rc | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | NetworkManager-1.4.0-0.1.git20160606.b769b4df.el7 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-11-03 19:07:13 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Attachments: | |||
|
Description
Trae Santiago
2016-02-02 14:44:45 UTC
Please ignore the terrible formatting of output, I had to copy and paste. The MTU is not set because the team connection doesn't have any IP configuration and we change the MTU in ip4_config_pre_commit() of nm-device-team.c; probably we should move the change of MTU to another callback that runs also when there is no IP configuration. Created attachment 1137401 [details]
[PATCH] device: apply MTU setting also to devices without IPv4 configuration
Patch for master.
*** Bug 1303731 has been marked as a duplicate of this bug. *** (In reply to Beniamino Galvani from comment #4) > Created attachment 1137401 [details] > [PATCH] device: apply MTU setting also to devices without IPv4 configuration > > Patch for master. +static void +nm_device_apply_mtu_from_config (NMDevice *self) I would name static methods without nm_ prefix (although there are counter examples). + _LOGE (LOGD_DEVICE | LOGD_IP, + "setting MTU of device without IP4 config to %u", _LOGD? Rest lgtm Created attachment 1138952 [details] [PATCH v2] device: apply MTU setting also to devices without IPv4 configuration (In reply to Thomas Haller from comment #6) > I would name static methods without nm_ prefix (although there are counter > examples). > _LOGD? Both fixed, thanks. *** Bug 1316590 has been marked as a duplicate of this bug. *** This bug was accidentally moved from POST to MODIFIED via an error in automation, please see mmccune with any questions (In reply to Beniamino Galvani from comment #7) > Created attachment 1138952 [details] > [PATCH v2] device: apply MTU setting also to devices without IPv4 > configuration > > (In reply to Thomas Haller from comment #6) > > I would name static methods without nm_ prefix (although there are counter > > examples). > > > _LOGD? > > Both fixed, thanks. LGTM now. (In reply to Beniamino Galvani from comment #7) > Created attachment 1138952 [details] > [PATCH v2] device: apply MTU setting also to devices without IPv4 > configuration LGTM Merged to master: https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=53dfaddda2adad15f4fbf35780bc03503cc45a63 works fine now, mtu 9000 is set from slave over team to bridge Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHSA-2016-2581.html |