| Summary: | [Docs] Secrete Restrictions are not clear | ||||||
|---|---|---|---|---|---|---|---|
| Product: | OpenShift Container Platform | Reporter: | Eric Rich <erich> | ||||
| Component: | Documentation | Assignee: | Ashley Hardin <ahardin> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | weiwei jiang <wjiang> | ||||
| Severity: | medium | Docs Contact: | Vikram Goyal <vigoyal> | ||||
| Priority: | medium | ||||||
| Version: | 3.1.0 | CC: | aos-bugs, erich, jokerman, mmccomas, stwalter, wsun | ||||
| Target Milestone: | --- | Keywords: | NeedsTestCase | ||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2016-07-15 15:21:39 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Attachments: |
|
||||||
|
Description
Eric Rich
2016-02-02 19:23:39 UTC
Created attachment 1120804 [details]
Sample Files
Customer who read our documentation now expect the following flow to occur.
Deploy secret-sa.yml (oc create -f secret-sa.yml)
Deploy secret.yml (oc create -f secret.yml)
Deploy mysecurepod.yml as it have secret-sa service account, the pod can mount the secret, so it can be deployed (oc create -f mysecurepod.yml)
Deploy should-fail-pod.yml wich doesn't have secret-sa service account so it should not mount the secret and therefore should not be deployed (oc create -f should-fail-pod.yml)
- Note: This last item is not correct as the service account information only applies to "imagesecretes"
The section noted by Eric, https://docs.openshift.com/enterprise/3.0/dev_guide/secrets.html#restrictions, also creates confusion when compared to the following paragraph from https://docs.openshift.com/enterprise/3.1/admin_guide/service_accounts.html#infrastructure-service-accounts:
Set limitSecretReferences field in master configuration file to true to require pod secret references to be whitelisted by their service accounts. Set its value to false to allow pods to reference any secret in the namespace.
serviceAccountConfig:
...
limitSecretReferences: false
From the developer's perspective, the documentation indicates that a secret must be indicated in a pod's service account in order for the service account to mount the secret volume. However this is only true if the above variable is set in the master-config file, and this is only indicated in the cluster admin's service account page. The developer guide would likely benefit from an indication that the cluster administrator would need to enable this; as there is no real cluster administrator page on secrets, there should at least be a reference in the developer's guide to this effect.
Work in progress: https://github.com/openshift/openshift-docs/pull/2325 @Eric- Please review. Thanks! (In reply to Ashley Hardin from comment #3) > Work in progress: https://github.com/openshift/openshift-docs/pull/2325 > > @Eric- Please review. Thanks! LGTM Checked and the doc looks better now. Commits pushed to master at https://github.com/openshift/openshift-docs https://github.com/openshift/openshift-docs/commit/dbf6c5a36552039376e38c2f583fb7b947e61c16 Bug 1304067, added clarifying details to the Secret Restrictions section https://github.com/openshift/openshift-docs/commit/4364b8b078a21438f4e8d3c116c9cf6cc1ffd2d6 Merge pull request #2325 from ahardin-rh/serviceaccount-secret Bug 1304067, added clarifying details to the Secret Restrictions section |