Bug 1304502

Summary: systemd-modules-load.service fails to start
Product: [Fedora] Fedora Reporter: Franco Comida <francocomida>
Component: systemdAssignee: systemd-maint
Status: CLOSED EOL QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 23CC: eliadevito, johannbg, junk, lnykryn, mark.harfouche, msekleta, muadda, s, systemd-maint, van.de.bugger, zbyszek
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-12-20 18:24:57 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
Patch that fixes the issue none

Description Franco Comida 2016-02-03 20:19:07 UTC
Created attachment 1120898 [details]
Patch that fixes the issue

Description of problem:
systemd-modules-load.service fails to start because /etc/modules-load.d is missing in initramfs and unit file does not check for it and skips it silently.

Version-Release number of selected component (if applicable):
systemd-222-13.fc23.x86_64 and previous ones

How reproducible:
Always

Steps to Reproduce:
1. It showed up in my box after installing VirtualBox

Actual results:
systemd[1]: Failed to start Load Kernel Modules. in logs
RED error message on boot screen.

Expected results:
No error shown, expecially on boot.

Additional info:
I modified unit file in order to check for relevant paths existence and I am providing a patch that fixes this issue for me.

Comment 1 Raphael Groner 2016-02-03 20:37:20 UTC
$ rpm -qf /etc/modules-load.d
systemd-222-13.fc23.x86_64

Did you try to recreate initrd with dracut?

Comment 2 Franco Comida 2016-02-03 23:59:50 UTC
I recreate initramfs with dracut adding missing /etc/modules-load.d and that fixed the issue.
I think it is a systemd bug because systemd should not fail if that path is missing but just silently skip it over as stated in systemd.unit manpage

Comment 3 Mark Harfouche 2016-05-02 21:38:09 UTC
So weird. I've been noticing that same message on my machines.

This is the output I get when checking the error. 
# systemctl status systemd-modules-load.service 
● systemd-modules-load.service - Load Kernel Modules
   Loaded: loaded (/usr/lib/systemd/system/systemd-modules-load.service; static; vendor preset: disabled)
   Active: active (exited) since Mon 2016-05-02 14:29:53 PDT; 1min 47s ago
     Docs: man:systemd-modules-load.service(8)
           man:modules-load.d(5)
  Process: 572 ExecStart=/usr/lib/systemd/systemd-modules-load (code=exited, status=0/SUCCESS)
 Main PID: 572 (code=exited, status=0/SUCCESS)
   CGroup: /system.slice/systemd-modules-load.service

May 02 14:29:53 foxtrot systemd[1]: Started Load Kernel Modules.

Comment 4 L.L.Robinson 2016-07-02 10:34:48 UTC
I have this error on two different machines, one with the rbd ceph driver and the other with the vhba cdemu driver

Comment 5 Franco Comida 2016-07-02 14:37:20 UTC
It fails even recreating initramfs.

systemd-modules-load[3749]: Failed to insert 'vboxdrv': Operation not permitted

Selinux related: if I disable selinux (setenforce=0; systemctl restart systemd-modules-load.service) it succeeds.

I have an EFI machine with disabled Secure Boot, it worked on F23 with only a warning that "signature and/or required key missing" taints the kernel

Comment 6 Van de Bugger 2016-08-14 13:53:27 UTC
I have the same or similar problem on several machines running F24:

# systemctl restart systemd-modules-load
Job for systemd-modules-load.service failed because the control process exited with error code. See "systemctl status systemd-modules-load.service" and "journalctl -xe" for details.

# systemctl status systemd-modules-load
● systemd-modules-load.service - Load Kernel Modules
   Loaded: loaded (/usr/lib/systemd/system/systemd-modules-load.service; static; vendor preset: disabled)
   Active: failed (Result: exit-code) since Sun 2016-08-14 16:36:42 MSK; 20s ago
     Docs: man:systemd-modules-load.service(8)
           man:modules-load.d(5)
  Process: 7669 ExecStart=/usr/lib/systemd/systemd-modules-load (code=exited, status=1/FAILURE)
 Main PID: 7669 (code=exited, status=1/FAILURE)

Aug 14 16:36:42 antec.home systemd[1]: Starting Load Kernel Modules...
Aug 14 16:36:42 antec.home systemd-modules-load[7669]: Failed to insert 'vboxdrv': Operation not permitted
Aug 14 16:36:42 antec.home systemd[1]: systemd-modules-load.service: Main process exited, code=exited, status=1/FAILURE
Aug 14 16:36:42 antec.home systemd[1]: Failed to start Load Kernel Modules.
Aug 14 16:36:42 antec.home systemd[1]: systemd-modules-load.service: Unit entered failed state.
Aug 14 16:36:42 antec.home systemd[1]: systemd-modules-load.service: Failed with result 'exit-code'.

# journalctl -b0 | grep systemd-modules-load
...
Aug 14 16:35:51 antec.home audit[1]: SERVICE_START pid=1 uid=0 auid=4294967295 ses=4294967295 subj=system_u:system_r:init_t:s0 msg='unit=systemd-modules-load comm="systemd" exe="/usr/lib/systemd/systemd" hostname=? addr=? terminal=? res=failed'
Aug 14 16:35:51 antec.home systemd[1]: systemd-modules-load.service: Failed with result 'exit-code'.
Aug 14 16:36:42 antec.home systemd-modules-load[7669]: Failed to insert 'vboxdrv': Operation not permitted
Aug 14 16:36:42 antec.home systemd-modules-load[7669]: Failed to insert 'vboxnetflt': Operation not permitted
Aug 14 16:36:42 antec.home systemd-modules-load[7669]: Failed to insert 'vboxnetadp': Operation not permitted
Aug 14 16:36:42 antec.home systemd-modules-load[7669]: Failed to insert 'vboxpci': Operation not permitted
Aug 14 16:36:42 antec.home systemd[1]: systemd-modules-load.service: Main process exited, code=exited, status=1/FAILURE
Aug 14 16:36:42 antec.home audit[1]: SERVICE_START pid=1 uid=0 auid=4294967295 ses=4294967295 subj=system_u:system_r:init_t:s0 msg='unit=systemd-modules-load comm="systemd" exe="/usr/lib/systemd/systemd" hostname=? addr=? terminal=? res=failed'
Aug 14 16:36:42 antec.home systemd[1]: systemd-modules-load.service: Unit entered failed state.
Aug 14 16:36:42 antec.home systemd[1]: systemd-modules-load.service: Failed with result 'exit-code'.


At the same time, all the failed modules can be successfully loaded by modprobe from root account, e. g.:

# modprobe vboxdrv; echo $?
0

# modprobe vboxnetflt; echo $?
0

etc. Proposed patch works for me.

Comment 7 Van de Bugger 2016-08-14 13:58:11 UTC
Sorry, sent message too early. 

Proposed patch does NOT work for me.

Comment 8 Elia Devito 2016-08-25 00:38:25 UTC
related/duplicate: https://bugzilla.redhat.com/show_bug.cgi?id=1254340

Comment 9 Fedora End Of Life 2016-11-24 15:22:48 UTC
This message is a reminder that Fedora 23 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 23. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '23'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 23 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 10 Fedora End Of Life 2016-12-20 18:24:57 UTC
Fedora 23 changed to end-of-life (EOL) status on 2016-12-20. Fedora 23 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.