Bug 1304512

Summary:	Packstack replaces httpd config with one without conf.modules.d
Product:	[Community] RDO	Reporter:	Patrick Uiterwijk <puiterwijk>
Component:	openstack-puppet-modules	Assignee:	Lukas Bezdicka <lbezdick>
Status:	CLOSED EOL	QA Contact:	Shai Revivo <srevivo>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	Liberty	CC:	aortega, apevec, derekh, lbezdick, srevivo
Target Milestone:	---
Target Release:	Kilo
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-05-19 15:51:51 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Patrick Uiterwijk 2016-02-03 21:17:56 UTC

Description of problem:
packstack --allinone replaces /etc/httpd/conf/httpd.conf with one that doesn't include /etc/httpd/conf.modules.d/*.conf, which means that any extra modules aren't loaded.

Version-Release number of selected component (if applicable):
openstack-packstack-1:7.0.0-0.10.dev1682.g42b3426.el7

How reproducible:
Consistent

Steps to Reproduce:
1. Run packstack --allinone

Actual results:
An httpd config that doesn't load conf.modules.d

Expected results:
An httpd config that contains the following line: IncludeOptional "/etc/httpd/conf.modules.d/*.conf"


Additional info:
Installed from CentOS centos-release-openstack-liberty.noarch

Comment 1 Alan Pevec 2016-02-03 22:16:37 UTC

RDO Liberty contains openstack-puppet-modules-7.0.1-1.el7 please update to the latest 7.0.6 from OPM stable/liberty branch.

Comment 2 Alan Pevec 2016-02-03 22:27:15 UTC

But even in 7.0.1, httpd.conf template DOES have that IncludeOptional line:
https://github.com/redhat-openstack/openstack-puppet-modules/blob/7.0.1/apache/templates/httpd.conf.erb#L80
so I'm not sure what's going on here!

Comment 3 Patrick Uiterwijk 2016-02-03 22:41:12 UTC

I can only find IncludeOptional "<%= @confd_dir %>/*.conf", which is conf.d/*.conf.

That file did appear in the generated config.
The missing one is conf.modules.d/*.conf: note the missing .modules

Comment 4 Alan Pevec 2016-02-04 10:31:25 UTC

ok, I should read bz description more carefully!
So the template has:
<% if @mod_load_dir != @confd_dir and @mod_load_dir != @vhost_load_dir -%>
Include "<%= @mod_load_dir %>/*.conf"
<% end -%>

but default for osfamily == 'RedHat' is:
 $mod_dir              = "${httpd_dir}/conf.d"
hence it is not included. Bug in puppet-apache?

Comment 5 Alan Pevec 2016-02-04 11:48:07 UTC

apache module will be bumped:
https://github.com/puppetlabs/puppetlabs-apache/commit/e825422b0080e66b32cd05ed51b5ccae69325c74

Comment 7 Chandan Kumar 2016-05-19 15:51:51 UTC

This bug is against a Version which has reached End of Life.
If it's still present in supported release (http://releases.openstack.org), please update Version and reopen.