Bug 1304889

Summary:	Memory leak in dht
Product:	[Community] GlusterFS	Reporter:	Vijay Bellur <vbellur>
Component:	distribute	Assignee:	Vijay Bellur <vbellur>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.7.7	CC:	bugs, sabansal
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.7.8	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1303945	Environment:
Last Closed:	2016-04-19 07:23:04 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1303945
Bug Blocks:

Description Vijay Bellur 2016-02-04 22:10:00 UTC

+++ This bug was initially created as a clone of Bug #1303945 +++

Description of problem:

Any rename operation causes a leak in dht. This is due to a dictionary which is not being currently freed in dht_do_rename(). 

Version-Release number of selected component (if applicable):


How reproducible:
Always

Steps to Reproduce:
1. Perform renames on a fuse/nfs mount point
2. Check the memory usage of fuse client or nfs server


Actual results:
Memory usage increases with more renames being done.

Expected results:
Memory usage should remain stable even with multiple renames.


Additional info:

Comment 1 Vijay Bellur 2016-02-04 22:13:28 UTC

REVIEW: http://review.gluster.org/13358 (cluster/dht: Cleanup dict in dht_do_rename()) posted (#1) for review on release-3.7 by Vijay Bellur (vbellur)

Comment 2 Vijay Bellur 2016-02-08 13:26:34 UTC

COMMIT: http://review.gluster.org/13358 committed in release-3.7 by Pranith Kumar Karampuri (pkarampu) 
------
commit 3db831788c3bd0d0a47466ad715894d27535e1b9
Author: Vijay Bellur <vbellur>
Date:   Fri Jan 29 15:59:24 2016 -0500

    cluster/dht: Cleanup dict in dht_do_rename()
    
    Change-Id: Ib4b3a843e78eccf5b8e0e7776cd0128013a59a3e
    BUG: 1304889
    Signed-off-by: Vijay Bellur <vbellur>
    Reviewed-on: http://review.gluster.org/13322
    CentOS-regression: Gluster Build System <jenkins.com>
    Smoke: Gluster Build System <jenkins.com>
    Reviewed-by: Kaleb KEITHLEY <kkeithle>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Raghavendra G <rgowdapp>
    Reviewed-on: http://review.gluster.org/13358

Comment 3 Vijay Bellur 2016-02-25 05:29:01 UTC

REVIEW: http://review.gluster.org/13513 (dht: cleanup dict and free memory in rename code path) posted (#1) for review on release-3.7 by Sakshi Bansal

Comment 4 Vijay Bellur 2016-02-26 03:19:42 UTC

COMMIT: http://review.gluster.org/13513 committed in release-3.7 by Raghavendra G (rgowdapp) 
------
commit 06b31594bfdc22220e9d7875d19f476cc8d3c426
Author: Sakshi Bansal <sabansal>
Date:   Mon Feb 8 12:14:12 2016 +0530

    dht: cleanup dict and free memory in rename code path
    
    Backport of http://review.gluster.org/#/c/13392/
    
    > Change-Id: I2458e18197bdf7565563a85e9021b5b2850c1825
    > BUG: 1303945
    > Signed-off-by: Sakshi Bansal <sabansal>
    > Reviewed-on: http://review.gluster.org/13392
    > Smoke: Gluster Build System <jenkins.com>
    > Reviewed-by: Xavier Hernandez <xhernandez>
    > CentOS-regression: Gluster Build System <jenkins.com>
    > NetBSD-regression: NetBSD Build System <jenkins.org>
    > Reviewed-by: Raghavendra G <rgowdapp>
    
    BUG: 1304889
    Change-Id: Ibda96769be2bd5b2708066d83363633fd7286929
    Signed-off-by: Sakshi Bansal <sabansal>
    Reviewed-on: http://review.gluster.org/13513
    Smoke: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.com>
    Reviewed-by: Raghavendra G <rgowdapp>

Comment 5 Kaushal 2016-04-19 07:23:04 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.9, please open a new bug report.

glusterfs-3.7.9 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://www.gluster.org/pipermail/gluster-users/2016-March/025922.html
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 6 Kaushal 2016-04-19 07:41:21 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.8, please open a new bug report.

glusterfs-3.7.8 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://www.gluster.org/pipermail/gluster-users/2016-February/025292.html
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user