Bug 1305011

Summary:	Sorting of LUNs doesn't work
Product:	Red Hat Enterprise Virtualization Manager	Reporter:	Pavel Zhukov <pzhukov>
Component:	ovirt-engine	Assignee:	Benny Zlotnik <bzlotnik>
Status:	CLOSED ERRATA	QA Contact:	Raz Tamir <ratamir>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	3.6.2	CC:	amureini, derez, gklein, lsurette, oourfali, rbalakri, Rhev-m-bugs, srevivo, tnisan, vszocs, ykaul, ylavi
Target Milestone:	ovirt-4.1.0-beta	Keywords:	UserExperience
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-04-25 01:02:14 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Storage	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Pavel Zhukov 2016-02-05 10:14:39 UTC

Description of problem:
I'm trying to sort LUNs in "New domain" dialog. Cursor changed but nothing happens if either one of column's title clicked (I'd like to have them sorted by ProductID)

Version-Release number of selected component (if applicable):
rhevm-3.6.2.6-0.1.el6.noarch

How reproducible:
100%

Steps to Reproduce:
1. New domain -> target IP -> Discover -> Click on ProductID


Actual results:
Nothing changes

Expected results:
Sorted by product ID

Additional info:
Failed to find if already reported.

Comment 1 Oved Ourfali 2016-02-16 11:55:21 UTC

If UX relevant, please move back to UX.

Comment 2 Benny Zlotnik 2017-01-10 16:18:08 UTC

I checked it and we do not have support for sortable tables in popups

Comment 3 Oved Ourfali 2017-01-11 12:58:35 UTC

I missed the fact that it is about a pop-up.
Vojtech - any thoughts?

Comment 4 Vojtech Szocs 2017-01-11 16:47:12 UTC

(In reply to Benny Zlotnik from comment #2)
> I checked it and we do not have support for sortable tables in popups

All UI tables (should) have the sorting capability. Code that adds individual columns to the table can specify that the given column is sortable.

The relevant code is SanStorageLunToTargetList. The code that adds "Product ID" column does not mark the column as sortable.

I've opened the dialog in both Firefox and Chrome (latest master) and cursor doesn't change when hovering the "Product ID" column, so I'm confused here.

(In reply to Oved Ourfali from comment #3)
> I missed the fact that it is about a pop-up.
> Vojtech - any thoughts?

The table in question (SanStorageLunToTargetList) should explicitly mark its columns as sortable, therefore a code change is needed.

Comment 6 Raz Tamir 2017-01-22 16:47:19 UTC

Verified on ovirt-engine-4.1.0.3-0.0.master.20170122091652.gitc6fc2c2.el7.centos
The LUNs can be sorted by product ID or any other column