Bug 1305091

I just noticed that upstream bundled some libraries. Trying to unbundle it.

Also, there are some points before review:

1) The `%if 0%{?rhel} && 0%{?rhel} <= 6` condition is used multiple times.
I personally prefer using something like that:

  %if 0%{?rhel} >= 7
  %global _with_systemd	 1
  %endif
  %if 0%{?fedora}
  %global _with_systemd	 1
  %endif
  ...
  %post
  %if 0%{?_with_systemd}
  %systemd_post %{name}.service
  %else
  /sbin/chkconfig --add %{name}
  %endif

(In other words, one global instead of multiple conditions). It looks more gracefully but sure, your option is also applicable;

2) Please wrap all el5-specific stuff into conditionals. Like that:
  %{?el5:BuildRoot:	%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)}
  ...
  %install
  %if 0%{?el5}
  rm -rf %{buildroot}
  %endif

3) Please add `%clean` section needed for el5.
  %if 0%{?el5}
  %clean
  rm -rf %{buildroot}
  %endif

4) Add all BRs (coreutils, gcc, make) required since there is no package exception list anymore;

5) This also can be replaced with single `install`:
  mkdir -p %{buildroot}%{_libexecdir}/%{name}
  cp -pr sinks %{buildroot}%{_libexecdir}/%{name}

Thank you for review. 

Unbundling will take some time as some of the deps are not in Fedora yet, and the source needs to be patched.

1,2,3) Agree, will implement

4) Aren't these part of the buildroot, thus not needed?

5) tried this initially but couldn't get it working because of the subdirs in sinks. Will check the man pages again, maybe I just missed some option.

(In reply to Piotr Popieluch from comment #3)
> 4) Aren't these part of the buildroot, thus not needed?

They usually do, but it can be changed in the future.
Some details https://fedorahosted.org/fpc/ticket/497#comment:20

Please note the changes at https://fedoraproject.org/w/index.php?title=Packaging%3AGuidelines&diff=413629&oldid=409506
And the current version is: https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRequires_2

6) As for the Source0, a simplified version is also OK:
  Source0: https://github.com/armon/statsite/archive/v%{version}.tar.gz
But sure, if you feel that you need that "%{name}-%{version}" tail, it can be kept for sure.

(In reply to Piotr Popieluch from comment #3)
> 5) tried this initially but couldn't get it working because of the subdirs
> in sinks. Will check the man pages again, maybe I just missed some option.
I think you're right. Didn't come up with a logical solution, so just keep the existing one. As for bundled files, let me know when I can proceed with the review.

Any progress with it?

I'm sorry for the delay. I'm having some issues with unbundling, the application keeps coredumping on libev. Upstream master branch switched from libev to the redis event library, will focus on upstream/master. I will try to get some time for this later this week.

Sorry for long delay, I didn't manage to get the libraries unbundled and lost interest in packaging this. closing