Bug 1305390
| Summary: | Review Request: dreamchess-tools - DreamChess Tools | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Raphael Groner <projects.rg> |
| Component: | Package Review | Assignee: | Rex Dieter <rdieter> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, rdieter |
| Target Milestone: | --- | Flags: | rdieter:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-03-27 21:58:11 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1140403, 1305382 | ||
| Bug Blocks: | |||
|
Description
Raphael Groner
2016-02-07 22:41:30 UTC
1. SHOULD replace multiline/complicated:
libtoolize --force
aclocal
autoheader
automake --force-missing --add-missing
autoconf
with:
autoreconf --force --install
2. FTBFS,
checking for SDL_ttf.h... no
configure: error: Cannot find
SDL_ttf header file
Hrm, trying to figure out what satisfies this (apparently not SDL2_ttf-devel)
2. MUST add BuildRequires: SDL_ttf-devel otherwise, naming: ok license: ok sources: ok c46192e1b07fa437f9ba7467cde3956f dreamchess-tools-f8f32aa6fed41d82b4577dbce6f7eb106a9eb63e.tar.gz 3. scriptlets: NOT ok, remove needless icon scriptlets (package includes no icons) 4. SHOULD improve %description, really no idea what this package is for or what it does. APPROVED. (I'll leave the MUST FTBFS fix to you, since it won't build without it) Thanks for the review! For completeness: Spec URL: https://raphgro.fedorapeople.org/review/chess/dreamchess/dreamchess-tools.spec SRPM URL: https://raphgro.fedorapeople.org/review/chess/dreamchess/dreamchess-tools-0-0.2.20141101gitf8f32aa.fc23.src.rpm %changelog * Tue Mar 22 2016 Raphael Groner <projects.rg> - 0-0.2.20141101gitf8f32aa - add BR: pkgconfig(SDL_ttf), remove icon scriptlets, use autoreconf Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=13428424 Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/dreamchess-tools dreamchess-tools-0-0.2.20141101gitf8f32aa.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-062d911117 dreamchess-tools-0-0.2.20141101gitf8f32aa.fc23 tristripper-1.10-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-0b0250e202 dreamchess-tools-0-0.2.20141101gitf8f32aa.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-062d911117 dreamchess-tools-0-0.2.20141101gitf8f32aa.fc23, tristripper-1.10-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-0b0250e202 dreamchess-tools-0-0.2.20141101gitf8f32aa.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. dreamchess-tools-0-0.2.20141101gitf8f32aa.fc23, tristripper-1.10-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. |