Bug 1305512
| Summary: | multiple definition of struct fsxattr when building qemu, collision between xfs_fs.h and fs.h | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Menanteau Guy <menantea> |
| Component: | xfsprogs | Assignee: | Kernel Maintainer List <kernel-maint> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 24 | CC: | amit.shah, berrange, cfergeau, crobinso, dchinner, dwmw2, esandeen, gansalmon, hannsj_uhl, itamar, jonathan, kernel-maint, madhu.chinakonda, mchehab, pbonzini, pbrobinson, rjones, virt-maint |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | ppc64le | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | xfsprogs-4.5.0-1.fc23 xfsprogs-4.5.0-1.fc24 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-03-21 23:53:19 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1071880, 1051573, 1304377, 1308252 | ||
|
Description
Menanteau Guy
2016-02-08 13:09:29 UTC
This kernel commit seems to be the culprit:
commit 334e580a6f97e2e84d1c19a8679603956acaa622
Author: Dave Chinner <dchinner>
Date: Mon Jan 4 16:44:15 2016 +1100
fs: XFS_IOC_FS[SG]SETXATTR to FS_IOC_FS[SG]ETXATTR promotion
Moves the fsxattr definition from xfs_fs.h to fs.h, but xfsprogs is still shipping the old header. Not really sure what the fix is, moving to kernel for further triage
Dave, Eric, is this something xfsprogs needs to cope with? yep, I guess so.
We can probably wrap it in
#ifndef FS_IOC_FSGETXATTR
in userspace, because that's the new ioctl that came after the "hoisting"
As a short term workaround, if you can define HAS_FSXATTR for the qemu build, that should keep the current xfsprogs definition out of it:
#ifndef HAVE_FSXATTR
struct fsxattr {
...
Perhaps the kernel should also #define HAVE_FSXATTR to make existing/older xfsprogs headers skip the definition... I've sent a patch for xfsprogs to guard in the other direction. any timeline for a build? This bug appears to have been reported against 'rawhide' during the Fedora 24 development cycle. Changing version to '24'. More information and reason for this action is here: https://fedoraproject.org/wiki/Fedora_Program_Management/HouseKeeping/Fedora24#Rawhide_Rebase I'm fixing this in QEMU by removing the xfsprogs dependency; on modern kernels fallocate does everything that QEMU used xfsctl for. xfsprogs-4.5.0-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-bce977a3af xfsprogs-4.5.0-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-82e630d3da xfsprogs-4.5.0-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-bce977a3af xfsprogs-4.5.0-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-82e630d3da xfsprogs-4.5.0-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. xfsprogs-4.5.0-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. |