Bug 1305835

Summary:	Remove nasty rpmmacro redefine
Product:	[Fedora] Fedora	Reporter:	Ondrej Vasik <ovasik>
Component:	sed	Assignee:	Petr Stodulka <pstodulk>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	hhorak, jpacner, pbonzini, pstodulk
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	sed-4.2.2-15.fc24	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-02-09 12:44:05 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Ondrej Vasik 2016-02-09 11:28:04 UTC

Description of problem:
sed.spec redefines system macro _bindir to /bin . This is not something spec file should usually do. I would prefer to simplify the spec, remove the redefine and ship sed normally in /usr/bin/sed .

Current solution is confusing for anyone who parses the spec files.

How reproducible:
always


Steps to Reproduce:
1. Check rpm -ql sed ... listed as /bin/sed - as specfile redefines _bindir

Actual results:
listed as /bin/sed - as specfile redefines _bindir

Expected results:
listed as /usr/bin/sed
(please make sure sed provides /bin/sed later on - as there may be file dependencies)

Additional info: Nasty hack introduced by http://pkgs.fedoraproject.org/cgit/rpms/sed.git/commit/?id=dc295e904f97e72c96ac98038b42aab39f5fb501

Comment 1 Ondrej Vasik 2016-02-09 11:29:20 UTC

(as a sidenote, this construction was maybe completely valid in 2004, in times of RHL 7.1, but should not be part of current Fedora.)

Comment 2 Petr Stodulka 2016-02-09 12:20:18 UTC

Yes, it was discussed during December but I have forgotten it.

Comment 3 Petr Stodulka 2016-02-09 12:44:05 UTC

Macro is removed + added provides of /bin/sed for packages which require this binary directly.