Bug 1306409

Summary:	Review Request: perl-Test2 - Framework for writing test tools that all work together
Product:	[Fedora] Fedora	Reporter:	Petr Pisar <ppisar>
Component:	Package Review	Assignee:	Jitka Plesnikova <jplesnik>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jplesnik, package-review
Target Milestone:	---	Flags:	jplesnik: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-Test2-0.000025-1.fc24	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-02-11 15:35:19 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Bug Depends On:
Bug Blocks:	1306613, 1307044

Description Petr Pisar 2016-02-10 18:31:08 UTC

Spec URL: https://ppisar.fedorapeople.org/perl-Test2/perl-Test2.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Test2/perl-Test2-0.000025-1.fc24.src.rpm
Description:
Test2 is a new Perl testing framework produced by forking Test::Builder,
completely refactoring it, adding many new features and capabilities.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2016-02-11 09:22:29 UTC

Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Test2-0.000025-1.fc24.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.22.1)
      1 perl(Carp)
      1 perl(Config)
      1 perl(Exporter)
      1 perl(File::Spec)
      1 perl(File::Temp)
      1 perl(IPC::SysV)
      1 perl(Scalar::Util)
      1 perl(Storable)
      1 perl(Test2::API)
      1 perl(Test2::API::Instance)
      1 perl(Test2::API::Stack)
      1 perl(Test2::Event)
      1 perl(Test2::Event::Bail)
      1 perl(Test2::Event::Diag)
      1 perl(Test2::Event::Exception)
      1 perl(Test2::Event::Note)
      1 perl(Test2::Event::Ok)
      1 perl(Test2::Event::Plan)
      1 perl(Test2::Event::Skip)
      1 perl(Test2::Event::Subtest)
      1 perl(Test2::Event::Waiting)
      1 perl(Test2::Formatter)
      1 perl(Test2::Hub)
      1 perl(Test2::Hub::Interceptor)
      1 perl(Test2::Hub::Interceptor::Terminator)
      1 perl(Test2::Hub::Subtest)
      1 perl(Test2::IPC::Driver)
      1 perl(Test2::Util)
      1 perl(Test2::Util::ExternalMeta)
      1 perl(Test2::Util::HashBase)
      1 perl(Test2::Util::Trace)
      1 perl(base)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Test2-0.000025-1.fc24.noarch.rpm | sort | uniq -c
      1 perl(Test2) = 0.000025
      1 perl(Test2::API)
      1 perl(Test2::API::Context)
      1 perl(Test2::API::Instance)
      1 perl(Test2::API::Stack)
      1 perl(Test2::Event)
      1 perl(Test2::Event::Bail)
      1 perl(Test2::Event::Diag)
      1 perl(Test2::Event::Exception)
      1 perl(Test2::Event::Note)
      1 perl(Test2::Event::Ok)
      1 perl(Test2::Event::Plan)
      1 perl(Test2::Event::Skip)
      1 perl(Test2::Event::Subtest)
      1 perl(Test2::Event::Waiting)
      1 perl(Test2::Formatter)
      1 perl(Test2::Formatter::TAP)
      1 perl(Test2::Hub)
      1 perl(Test2::Hub::Interceptor)
      1 perl(Test2::Hub::Interceptor::Terminator)
      1 perl(Test2::Hub::Subtest)
      1 perl(Test2::IPC)
      1 perl(Test2::IPC::Driver)
      1 perl(Test2::IPC::Driver::Files)
      1 perl(Test2::Util)
      1 perl(Test2::Util::ExternalMeta)
      1 perl(Test2::Util::HashBase)
      1 perl(Test2::Util::Trace)
      1 perl-Test2 = 0.000025-1.fc24
Binary provides are Ok.

$ rpmlint ./perl-Test2*
perl-Test2.noarch: W: spelling-error %description -l en_US refactoring -> re factoring, re-factoring, factoring
perl-Test2.src: W: spelling-error %description -l en_US refactoring -> re factoring, re-factoring, factoring
2 packages and 1 specfiles checked; 0 errors, 2 warnings.

Rpmlint is ok

The package looks good.
Approved.

Comment 2 Gwyn Ciesla 2016-02-11 13:40:19 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/perl-Test2

Comment 3 Petr Pisar 2016-02-11 15:35:19 UTC

Thank you for the review and the repository.