Bug 1306968 (php-mock/php-mock)

Summary: Review Request: php-mock - PHP-Mock can mock built-in PHP functions
Product: [Fedora] Fedora Reporter: Remi Collet <fedora>
Component: Package ReviewAssignee: Shawn Iwinski <shawn>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: package-review, shawn
Target Milestone: ---Flags: shawn: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-03-02 21:22:52 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1306971, 1306972    
Attachments:
Description Flags
phpcompatinfo-full.php
none
phpcompatinfo-lib.php
none
fedora-review.txt none

Description Remi Collet 2016-02-12 10:18:51 UTC 
Spec URL: https://raw.githubusercontent.com/remicollet/remirepo/0822a3a8879586381cc763d6d7b5a9612d5caf48/php/php-mock/php-mock/php-mock.spec
SRPM URL: http://rpms.famillecollet.com/SRPMS/php-mock-1.0.1-1.remi.src.rpm
Description: 
PHP-Mock can mock built-in PHP functions (e.g. time()).
PHP-Mock relies on PHP's namespace fallback policy.
No further extension is needed.

Fedora Account System Username: remi

Needed by ZF
Comment 1 Shawn Iwinski 2016-02-22 12:58:34 UTC 
Created attachment 1129308 [details]
phpcompatinfo-full.php

phpCompatInfo version 5.0.0 DB built Jan 09 2016 15:36:21 CET
Comment 2 Shawn Iwinski 2016-02-22 12:58:54 UTC 
Created attachment 1129309 [details]
phpcompatinfo-lib.php

phpCompatInfo version 5.0.0 DB built Jan 09 2016 15:36:21 CET
Comment 3 Shawn Iwinski 2016-02-22 12:59:24 UTC 
Created attachment 1129310 [details]
fedora-review.txt

Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20
Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1306968
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, PHP, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Comment 4 Shawn Iwinski 2016-02-22 12:59:49 UTC 
[!]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "*No copyright* WTFPL", "WTFPL", "Unknown or generated". 40
     files have unknown license.

     License is "WTFPL" not "BSD"
Comment 5 Remi Collet 2016-02-22 13:36:17 UTC 
Good catch:

Fix: https://github.com/remicollet/remirepo/commit/83268d38f0d76354c4b8d952d06d5f511ea8dd8a

spec: https://raw.githubusercontent.com/remicollet/remirepo/83268d38f0d76354c4b8d952d06d5f511ea8dd8a/php/php-mock/php-mock/php-mock.spec
Srpm: http://rpms.famillecollet.com/SRPMS/php-mock-1.0.1-2.remi.src.rpm
Comment 6 Shawn Iwinski 2016-02-22 14:14:17 UTC 
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "*No copyright* WTFPL", "WTFPL", "Unknown or generated". 40
     files have unknown license.



[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf %{buildroot} present but not required
[!]: Each %files section contains %defattr if rpm < 4.4
     Note: %defattr present but not needed
[!]: Buildroot is not present
     Note: Buildroot: present but not needed
[!]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
     Note: %clean present but not required

As usual, remove EPEL 5 bits after initial import.



No blockers.

===== APPROVED =====
Comment 7 Gwyn Ciesla 2016-02-22 14:53:06 UTC 
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/php-mock
Comment 8 Fedora Update System 2016-02-22 15:57:21 UTC 
php-mock-1.0.1-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-e1c6e043cf
Comment 9 Fedora Update System 2016-02-23 15:19:57 UTC 
php-mock-1.0.1-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-e1c6e043cf
Comment 10 Fedora Update System 2016-03-02 21:22:50 UTC 
php-mock-1.0.1-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.