Bug 1306972 (php-mock/php-mock-phpunit)

Summary: Review Request: php-mock-phpunit - Mock built-in PHP functions with PHPUnit.
Product: [Fedora] Fedora Reporter: Remi Collet <fedora>
Component: Package ReviewAssignee: Shawn Iwinski <shawn>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: package-review, shawn
Target Milestone: ---Flags: shawn: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-04-17 23:41:23 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1306968, 1306971    
Bug Blocks:    
Attachments:
Description Flags
phpcompatinfo-full.log
none
phpcompatinfo-lib.log
none
fedora-review.txt none

Description Remi Collet 2016-02-12 10:22:45 UTC
Spec URL: https://raw.githubusercontent.com/remicollet/remirepo/107af67ec619a1a5a5592fd32c8e52f1b87b3db2/php/php-mock/php-mock-phpunit/php-mock-phpunit.spec
SRPM URL: http://rpms.famillecollet.com/SRPMS/php-mock-phpunit-1.1.1-1.remi.src.rpm
Description: 
Mock built-in PHP functions (e.g. time()) with PHPUnit.
This package relies on PHP's namespace fallback policy.
No further extension is needed.

Fedora Account System Username: remi

Comment 2 Shawn Iwinski 2016-04-12 18:50:21 UTC
Created attachment 1146610 [details]
phpcompatinfo-full.log

phpCompatInfo version 5.0.0 DB built Mar 07 2016 07:28:32 CET

Comment 3 Shawn Iwinski 2016-04-12 18:51:11 UTC
Created attachment 1146611 [details]
phpcompatinfo-lib.log

phpCompatInfo version 5.0.0 DB built Mar 07 2016 07:28:32 CET

Comment 4 Shawn Iwinski 2016-04-12 18:52:04 UTC
Created attachment 1146614 [details]
fedora-review.txt

Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20
Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1306972
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, PHP, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Comment 5 Shawn Iwinski 2016-04-12 18:54:24 UTC
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf %{buildroot} present but not required
[!]: Each %files section contains %defattr if rpm < 4.4
     Note: %defattr present but not needed
[!]: Buildroot is not present
     Note: Buildroot: present but not needed
[!]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
     Note: %clean present but not required



[!]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).

     After initial import, fix "W: summary-ended-with-dot"



No blockers.

===== APPROVED =====

Comment 6 Gwyn Ciesla 2016-04-13 13:06:36 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/php-mock-phpunit

Comment 7 Fedora Update System 2016-04-13 13:53:37 UTC
php-mock-phpunit-1.1.1-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-c6aac73ae7

Comment 8 Fedora Update System 2016-04-13 13:53:44 UTC
php-mock-phpunit-1.1.1-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-a5b3c597e9

Comment 9 Fedora Update System 2016-04-13 21:22:55 UTC
php-mock-phpunit-1.1.1-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-c6aac73ae7

Comment 10 Fedora Update System 2016-04-14 04:52:13 UTC
php-mock-phpunit-1.1.1-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-a5b3c597e9

Comment 11 Fedora Update System 2016-04-17 23:41:20 UTC
php-mock-phpunit-1.1.1-2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

Comment 12 Fedora Update System 2016-04-22 01:22:22 UTC
php-mock-phpunit-1.1.1-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.