Bug 1307034
| Summary: | atomic fails for some characters in parameters | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | Jan Pazdziora (Red Hat) <jpazdziora> |
| Component: | atomic | Assignee: | Lokesh Mandvekar <lsm5> |
| Status: | CLOSED ERRATA | QA Contact: | atomic-bugs <atomic-bugs> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 7.2 | CC: | ajia, dwalsh, jpazdziora |
| Target Milestone: | rc | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-06-23 16:21:19 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
Jan is this still a problem with atomic-1.8? (In reply to Daniel Walsh from comment #3) > Jan is this still a problem with atomic-1.8? Yes. I've tested with atomic-1.8-3.gitcc5997a.fc23.x86_64. The non-ASCII issue has been fixed: # atomic install escapes --test ježek docker run --rm --name escapes -e NAME=escapes -e IMAGE=escapes escapes /bin/install.sh --test 'ježek' --test $'je\305\276ek' But the quote characters handling is still broken: # atomic install escapes --test 'asdf"asdf' /bin/sh: -c: line 0: unexpected EOF while looking for matching `'' /bin/sh: -c: line 1: syntax error: unexpected end of file # atomic install escapes --test "asdf'asdf" /bin/sh: -c: line 0: unexpected EOF while looking for matching `'' /bin/sh: -c: line 1: syntax error: unexpected end of file (In reply to Jan Pazdziora from comment #4) > (In reply to Daniel Walsh from comment #3) > > Jan is this still a problem with atomic-1.8? > > Yes. > > I've tested with atomic-1.8-3.gitcc5997a.fc23.x86_64. > > The non-ASCII issue has been fixed: > > # atomic install escapes --test ježek > docker run --rm --name escapes -e NAME=escapes -e IMAGE=escapes escapes > /bin/install.sh --test 'ježek' > --test > $'je\305\276ek' This fix was lost again in atomic 1.9: bug 1323165 comment 2. Fixed in atomic-1.10 I confirm that with python-docker-py-1.7.2-1.el7.noarch and atomic-1.10.3-2.el7.x86_64, installed, all cases from comment 0 pass. The atomic install escapes --test ježek produces $'je\305\276ek' but that is also valid. All of testing are passed in Comment 0, so move the bug to VERIFIED status. [cloud-user@atomic-host-001 ~]$ cat /etc/redhat-release Red Hat Enterprise Linux Atomic Host release 7.2 [cloud-user@atomic-host-001 ~]$ sudo atomic host status TIMESTAMP (UTC) VERSION ID OSNAME REFSPEC * 2016-06-06 18:12:07 7.2.5 4bf265cf86 rhel-atomic-host rhel-atomic-host-ostree:rhel-atomic-host/7/x86_64/standard 2016-05-06 05:57:30 7.2.4 b060975ce3 rhel-atomic-host rhel-atomic-host-ostree:rhel-atomic-host/7/x86_64/standard [cloud-user@atomic-host-001 ~]$ rpm -q atomic docker python-docker-py atomic-1.10.3-1.el7.x86_64 docker-1.10.3-31.el7.x86_64 python-docker-py-1.7.2-1.el7.noarch Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2016:1273 |
Description of problem: When non-alphanum characters are used as parameters to atomic command for example when passwords are passed in, atomic might fail. Version-Release number of selected component (if applicable): atomic-1.6-6.gitca1e384.el7.x86_64 How reproducible: Deterministic. Steps to Reproduce: 1. Dockerfile: FROM rhel7 ADD install.sh /bin/install.sh RUN chmod +x /bin/install.sh LABEL INSTALL 'docker run --name ${NAME} -e NAME=${NAME} -e IMAGE=${IMAGE} ${IMAGE} /bin/install.sh' 2. install.sh: #!/bin/bash for i in "$@" ; do printf '%q\n' "$i" >> /run/install-options done cat /run/install-options 3. Build image: docker build -t escapes . 4. Run: atomic install escapes --test 'asdf asdf' 5. Run: atomic install escapes --test 'asdf&asdf' 6. Run: atomic install escapes --test ježek 7. Run: atomic install escapes --test 'asdf"asdf' 8. Run: atomic install escapes --test "asdf'asdf" Actual results: # atomic install escapes --test 'asdf asdf' docker run --rm --name escapes -e NAME=escapes -e IMAGE=escapes escapes /bin/install.sh --test 'asdf asdf' --test asdf\ asdf # atomic install escapes --test 'asdf&asdf' docker run --rm --name escapes -e NAME=escapes -e IMAGE=escapes escapes /bin/install.sh --test 'asdf&asdf' --test asdf\&asdf # atomic install escapes --test ježek 'ascii' codec can't decode byte 0xc5 in position 3: ordinal not in range(128) # atomic install escapes --test 'asdf"asdf' /bin/sh: -c: line 0: unexpected EOF while looking for matching `'' /bin/sh: -c: line 1: syntax error: unexpected end of file # atomic install escapes --test "asdf'asdf" /bin/sh: -c: line 0: unexpected EOF while looking for matching `'' /bin/sh: -c: line 1: syntax error: unexpected end of file Expected results: # atomic install escapes --test 'asdf asdf' docker run --rm --name escapes -e NAME=escapes -e IMAGE=escapes escapes /bin/install.sh --test 'asdf asdf' --test asdf\ asdf # atomic install escapes --test 'asdf&asdf' docker run --rm --name escapes -e NAME=escapes -e IMAGE=escapes escapes /bin/install.sh --test 'asdf&asdf' --test asdf\&asdf # atomic install escapes --test ježek docker run --rm --name escapes -e NAME=escapes -e IMAGE=escapes escapes /bin/install.sh --test 'ježek' --test ježek # atomic install escapes --test 'asdf"asdf' docker run --rm --name escapes -e NAME=escapes -e IMAGE=escapes escapes /bin/install.sh --test 'asdf"asdf' --test asdf\"asdf # atomic install escapes --test "asdf'asdf" docker run --rm --name escapes -e NAME=escapes -e IMAGE=escapes escapes /bin/install.sh --test asdf\'asdf --test asdf\'asdf and no error reported. Additional info: