Bug 1307044

Summary:	Review Request: perl-Test2-Workflow - Interface for writing workflow tools such as RSPEC
Product:	[Fedora] Fedora	Reporter:	Petr Pisar <ppisar>
Component:	Package Review	Assignee:	Jitka Plesnikova <jplesnik>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jplesnik, package-review
Target Milestone:	---	Flags:	jplesnik: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-Test2-Workflow-0.000006-1.fc25	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-02-25 14:51:42 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1306409, 1306613
Bug Blocks:	1307199

Description Petr Pisar 2016-02-12 14:47:42 UTC

Spec URL: https://ppisar.fedorapeople.org/perl-Test2-Workflow/perl-Test2-Workflow.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Test2-Workflow/perl-Test2-Workflow-0.000006-1.fc24.src.rpm
Description:
These Perl modules intend to do for 'workflow' test tools what Test::Builder
and Test2 do for general test tools. The problem with workflow tools is that
most do not play well together. These modules provide a very generic/abstract
look at workflows that allows tools to be built that accomplish their
workflows, but in a way that plays well with others.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2016-02-25 11:07:24 UTC

Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Test2-Workflow-0.000006-1.fc24.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.22.1)
      1 perl(B)
      1 perl(Carp)
      1 perl(Exporter)
      1 perl(Import::Into) >= 1.002000
      1 perl(List::Util)
      1 perl(POSIX)
      1 perl(Scalar::Util)
      1 perl(Scope::Guard) >= 0.10
      1 perl(Test2) >= 0.000025
      1 perl(Test2::API)
      1 perl(Test2::API::Context)
      1 perl(Test2::Bundle::Extended)
      1 perl(Test2::Event)
      1 perl(Test2::Event::Stamp)
      1 perl(Test2::IPC)
      1 perl(Test2::Suite) >= 0.000020
      1 perl(Test2::Todo)
      1 perl(Test2::Tools::Mock)
      1 perl(Test2::Tools::Spec)
      1 perl(Test2::Util)
      1 perl(Test2::Util::HashBase)
      1 perl(Test2::Util::Sub)
      1 perl(Test2::Util::Trace)
      1 perl(Test2::Workflow)
      1 perl(Test2::Workflow::Meta)
      1 perl(Test2::Workflow::Runner)
      1 perl(Test2::Workflow::Runner::Isolate)
      1 perl(Test2::Workflow::Task)
      1 perl(Test2::Workflow::Task::Isolate)
      1 perl(Test2::Workflow::Unit)
      1 perl(Test2::Workflow::Util)
      1 perl(Time::HiRes)
      1 perl(base)
      1 perl(overload)
      1 perl(parent)
      1 perl(strict)
      1 perl(threads) >= 1.34
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Test2-Workflow-0.000006-1.fc24.noarch.rpm | sort | uniq -c
      1 perl(Test2::Bundle::Spec)
      1 perl(Test2::Event::Stamp)
      1 perl(Test2::Tools::Spec)
      1 perl(Test2::Workflow) = 0.000006
      1 perl(Test2::Workflow::Meta)
      1 perl(Test2::Workflow::Runner)
      1 perl(Test2::Workflow::Runner::Isolate)
      1 perl(Test2::Workflow::Runner::Isolate::Fork)
      1 perl(Test2::Workflow::Runner::Isolate::NoIso)
      1 perl(Test2::Workflow::Runner::Isolate::Threads)
      1 perl(Test2::Workflow::Task)
      1 perl(Test2::Workflow::Task::Isolate)
      1 perl(Test2::Workflow::Unit)
      1 perl(Test2::Workflow::Util)
      1 perl-Test2-Workflow = 0.000006-1.fc24
Binary provides are Ok.

$ rpmlint ./perl-Test2-Workflow*
perl-Test2-Workflow.noarch: W: spelling-error %description -l en_US workflows -> work flows, work-flows, workloads
perl-Test2-Workflow.src: W: spelling-error %description -l en_US workflows -> work flows, work-flows, workloads
2 packages and 1 specfiles checked; 0 errors, 2 warnings.

Rpmlint is ok

The package looks good.
Approved

Comment 2 Gwyn Ciesla 2016-02-25 14:20:42 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/perl-Test2-Workflow

Comment 3 Petr Pisar 2016-02-25 14:51:42 UTC

Thank you for the review and the repository.