| Summary: | Using 4096 length lv tag trashes lvm metadata | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Tony Asleson <tasleson> |
| Component: | lvm2 | Assignee: | Peter Rajnoha <prajnoha> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 23 | CC: | agk, bmarzins, bmr, dwysocha, heinzm, jonathan, lvm-team, msnitzer, prajnoha, prockai, zkabelac |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | lvm2-2.02.150-2.fc24.x86_64 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-08-01 09:17:34 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Tony Asleson
2016-02-12 23:39:33 UTC
This is only reproducible with lvmetad used (global/use_lvmetad=1), it works without lvmetad. Looking further... That was the 4096 character buffer size used when writing dm_config_node (which is used as part of the dm_config_tree when sending lvmetad metadata), it should be now fixed with: https://git.fedorahosted.org/cgit/lvm2.git/commit/?id=967a0889a024e2cc3f3afb3469e1b0657ebb85bc https://git.fedorahosted.org/cgit/lvm2.git/commit/?id=67c5006e12c9e3bf888db0fbaa78a50efcbfa9b2 === However, there's still something wrong that the failed vsnprintf before caused such harm to metadata! It should have errored out cleanly, not garbling metadata completely that it's not usable anymore! So this part still needs fixing! (In reply to Peter Rajnoha from comment #2) > However, there's still something wrong that the failed vsnprintf before > caused such harm to metadata! It should have errored out cleanly, not > garbling metadata completely that it's not usable anymore! So this part > still needs fixing! That was caused by dm_config_write_node (and all its variants) to not return error code properly if there was a failure during writing any subsection. So in this case the code assumed the dm_config_write_node was successful even though writing any subsection could have failed. Then, when communicating with lvmetad, incomplete metadata were sent. A very nice bug indeed! That should be fixed now with: https://git.fedorahosted.org/cgit/lvm2.git/commit/?id=9720898c8ee3a4035858508b38179a143d948f4f This bug was accidentally moved from POST to MODIFIED via an error in automation, please see mmccune with any questions |