Bug 1307200 (kjots)
| Summary: | Review Request: kjots - KDE Notes application | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Daniel Vrátil <me> |
| Component: | Package Review | Assignee: | Rex Dieter <rdieter> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | me, package-review, rdieter |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | Flags: | rdieter:
fedora-review+
|
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-05-10 11:47:10 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 656997 | ||
|
Description
Daniel Vrátil
2016-02-13 00:35:11 UTC
Offhand, for upgrade path, probably need to introduce at least: Epoch: 7 since that's what previous kdepim package used Nevermind, I see we foresaw that and included Epoch: 0 in the subpkgs before. naming: ok
sources: ok
edb0a82781dbb75d1fe69f2eb6f7cf28 kjots-5.0.1.tar.xz
license: ok
scriptlets: NOT ok
1. icon scriptlets reference (undefined?) macro: %{_iconsdir}, probably want instead: %{_datadir}/icons (or define %_iconsdir)
2. MUST add appdata validation scriptlet
https://fedoraproject.org/wiki/Packaging:AppData#app-data-validate_usage
3. SHOULD use better URL, something like
URL: http://projects.kde.org/kjots
4. MUST include licenses in %files, add:
%license COPYING
and optinally
%license COPYING.LIB
too
ping, can you give an update? Spec URL: https://dvratil.fedorapeople.org/spec/kjots.spec SRPM URL: https://dvratil.fedorapeople.org/spec/kjots-5.0.1-2.fc23.src.rpm * Mon Mar 14 2016 Daniel Vrátil <dvratil> - 5.0.1-2 - fix url - fix scriptlets - fix %%license and %%doc - validate appdata looks good, approved Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/kjots I see kjots imported and built, closing https://bodhi.fedoraproject.org/updates/kjots → 404 Can you provide an (at least test) build for Fedora 23? Raphael, this kjots package is only available in F24 and rawhide. On F23 we ship KDEPIM4, where KJots is available as part of the kdepim package. You talk about bug #1314974, right? No. In Fedora <= 23 we ship kdepim 4.14.x in package "kdepim" based on Qt4 and KDE4 (called usually "KDEPIM4"), which includes KJots and all the other KDE PIM applications. In F24 we updated to kdepim 15.12 as part of KDE Applications 15.12 release which is based on Qt5 and KF5 (called "KDEPIM5") and is not compatible with the KDE4 versions. KJots has been ported to Qt5 too, but is being released separately by upstream, not as part of KDE Applications. Therefore it's not part of the "kdepim4" compatibility package from bug #1314974, but a standalone package. kjots-5.0.1-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-53e405b0c8 kjots-5.0.1-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-53e405b0c8 kjots-5.0.1-2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. |