Bug 1307201

Summary: Custom Certificate Documentation for OSE v3 is invalid
Product: OpenShift Container Platform Reporter: James Radtke <jradtke>
Component: DocumentationAssignee: Ashley Hardin <ahardin>
Status: CLOSED CURRENTRELEASE QA Contact: James Radtke <jradtke>
Severity: medium Docs Contact: Vikram Goyal <vigoyal>
Priority: urgent    
Version: 3.1.0CC: aos-bugs, jliggitt, jokerman, jradtke, mmccomas
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-02-23 15:26:53 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description James Radtke 2016-02-13 00:42:44 UTC
Description of problem:
https://docs.openshift.com/enterprise/3.1/install_config/certificate_customization.html
".... associated with the publicMasterURL ..."

And you can see it does not exist in master-config.yaml
root@rh7osemst01 master]# grep publicMasterURL master-config.yaml
[root@rh7osemst01 master]# 

Version-Release number of selected component (if applicable):
3.1

How reproducible:
N/A

Steps to Reproduce:
1.N/A
2.
3.

Actual results:
N/A

Expected results:
I would like to see the document updated with the actual variable to update.
[root@rh7osemst01 master]# grep URL master-config.yaml
  logoutURL: ""
  masterPublicURL: https://openshift-cluster.aperture.lab:8443
  publicURL: https://openshift-cluster.aperture.lab:8443/console/
masterPublicURL: https://openshift-cluster.aperture.lab:8443
  assetPublicURL: https://openshift-cluster.aperture.lab:8443/console/
  masterPublicURL: https://openshift-cluster.aperture.lab:8443
  masterURL: https://openshift-cluster.aperture.lab:8443


Additional info:


Document URL: 

Section Number and Name: 

Describe the issue: 

Suggestions for improvement: 

Additional information:

Comment 1 Ashley Hardin 2016-02-15 18:00:02 UTC
Should publicMasterURL be replaced with masterPublicURL on this page?

https://docs.openshift.com/enterprise/3.1/install_config/certificate_customization.html

Both publicMasterURL and masterPublicURL exist in the code. 

@Jordan, can you please help clarify based on the following former PR? Not sure if this was a typo that got carried through. 

https://github.com/openshift/openshift-docs/issues/1143#issuecomment-162761543

Seems like I should update this section to read "associated with the masterPublicURL, assetConfig.publicURL, and oauthConfig.assetPublicURL settings." Please help verify. Thanks!

Comment 2 Jordan Liggitt 2016-02-15 18:17:49 UTC
It should be masterPublicURL, not publicMasterURL

Comment 3 Ashley Hardin 2016-02-15 19:23:58 UTC
@Jordan. thanks!

@James, please review these edits and let us know if this satisfies your request. Thanks! https://github.com/openshift/openshift-docs/pull/1590

Comment 4 James Radtke 2016-02-16 02:35:59 UTC
Look correct - thanks for the quick response!

Comment 5 openshift-github-bot 2016-02-16 13:56:01 UTC
Commits pushed to master at https://github.com/openshift/openshift-docs

https://github.com/openshift/openshift-docs/commit/42c5a541bcf7f0294003e36e5078564cdc0ca697
Bug 1307201, replaced publicMasterURL with masterPublicURL

https://github.com/openshift/openshift-docs/commit/b561e30340a8e12d0f3b32b280081dc3a0b5f50f
Merge pull request #1590 from ahardin-rh/custom-certificates

Bug 1307201, replaced publicMasterURL with masterPublicURL