Bug 1307216 (sebastian/code-unit-reverse-lookup)

Summary: Review Request: php-sebastian-code-unit-reverse-lookup - Looks up which function or method a line of code belongs to
Product: [Fedora] Fedora Reporter: Remi Collet <fedora>
Component: Package ReviewAssignee: Shawn Iwinski <shawn>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: package-review, shawn
Target Milestone: ---Flags: shawn: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-02-22 15:17:37 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
phpcompatinfo-full.php
none
phpcompatinfo-lib.php
none
fedora-review.txt none

Description Remi Collet 2016-02-13 08:05:33 UTC 
Spec URL: https://raw.githubusercontent.com/remicollet/remirepo/a8823e71c9e9759c4e02da60d2285836ba3079e8/php/phpunit/php-sebastian-code-unit-reverse-lookup/php-sebastian-code-unit-reverse-lookup.spec
SRPM URL: http://rpms.famillecollet.com/SRPMS/php-sebastian-code-unit-reverse-lookup-1.0.0-1.remi.src.rpm
Description: 
Looks up which function or method a line of code belongs to.

Fedora Account System Username: remi

-- 

New dependency of PHPUnit 5.2.5
Comment 1 Shawn Iwinski 2016-02-22 12:52:23 UTC 
Created attachment 1129298 [details]
phpcompatinfo-full.php

phpCompatInfo version 5.0.0 DB built Jan 09 2016 15:36:21 CET
Comment 2 Shawn Iwinski 2016-02-22 12:52:44 UTC 
Created attachment 1129299 [details]
phpcompatinfo-lib.php

phpCompatInfo version 5.0.0 DB built Jan 09 2016 15:36:21 CET
Comment 3 Shawn Iwinski 2016-02-22 12:53:13 UTC 
Created attachment 1129301 [details]
fedora-review.txt

Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20
Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1307216
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, PHP, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Comment 4 Shawn Iwinski 2016-02-22 12:54:44 UTC 
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf %{buildroot} present but not required
[!]: Each %files section contains %defattr if rpm < 4.4
     Note: %defattr present but not needed
[!]: Buildroot is not present
     Note: Buildroot: present but not needed
[!]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
     Note: %clean present but not required

As usual, remove EPEL 5 bits after initial import.



[x]: Requires correct, justified where necessary.

     Should BuildRequires virtual pkg "php-composer(theseer/autoload)"
     instead of file "%{_bindir}/phpab"



No blockers.

===== APPROVED =====
Comment 5 Gwyn Ciesla 2016-02-22 14:42:37 UTC 
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/php-sebastian-code-unit-reverse-lookup
Comment 6 Remi Collet 2016-02-22 15:17:37 UTC 
Only needed for PHPUnit 5.2, no plan to build in other branch than rawhide.