Bug 1307279

Summary: LabPlot: FTBFS in rawhide
Product: [Fedora] Fedora Reporter: Fedora Release Engineering <releng>
Component: LabPlotAssignee: Mukundan Ragavan <nonamedotc>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: chitlesh, i, nonamedotc, thibault.north, yselkowi
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-02-17 04:01:43 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1305208    
Attachments:
Description Flags
build.log
none
root.log
none
state.log none

Description Fedora Release Engineering 2016-02-13 20:56:16 UTC 
Your package LabPlot failed to build from source in current rawhide.

http://koji.fedoraproject.org/koji/taskinfo?taskID=12804331

For details on mass rebuild see https://fedoraproject.org/wiki/Fedora_24_Mass_Rebuild
Comment 1 Fedora Release Engineering 2016-02-13 20:56:18 UTC 
Created attachment 1123908 [details]
build.log
Comment 2 Fedora Release Engineering 2016-02-13 20:56:20 UTC 
Created attachment 1123909 [details]
root.log
Comment 3 Fedora Release Engineering 2016-02-13 20:56:22 UTC 
Created attachment 1123910 [details]
state.log
Comment 4 Yaakov Selkowitz 2016-02-17 03:11:28 UTC 
/builddir/build/BUILD/labplot-kf5-2.1.0/src/backend/worksheet/TextLabel.cpp: In member function 'virtual void TextLabelPrivate::mouseReleaseEvent(QGraphicsSceneMouseEvent*)':
/builddir/build/BUILD/labplot-kf5-2.1.0/src/backend/worksheet/TextLabel.cpp:538:38: error: call of overloaded 'abs(qreal)' is ambiguous
  if (abs(point.x()-position.point.x())>20 && qAbs(point.y()-position.point.y())>20 ) {

This both gives away the solution and makes you wonder what they were thinking at the same time.  Use qAbs() instead of abs() there.

Fix that though, and you get another issue further along:

/builddir/build/BUILD/labplot-kf5-2.1.0/src/backend/worksheet/plots/cartesian/CartesianCoordinateSystem.cpp: In member function ‘virtual QList<QLineF> CartesianCoordinateSystem::mapLogicalToScene(const QList<QLineF>&, const MappingFlags&) const’:
/builddir/build/BUILD/labplot-kf5-2.1.0/src/backend/worksheet/plots/cartesian/CartesianCoordinateSystem.cpp:560:27: error: ‘isnan’ was not declared in this scope
      if (!isnan(xGapBefore)) {
                           ^
/builddir/build/BUILD/labplot-kf5-2.1.0/src/backend/worksheet/plots/cartesian/CartesianCoordinateSystem.cpp:560:27: note: suggested alternative:
In file included from /builddir/build/BUILD/labplot-kf5-2.1.0/src/backend/worksheet/plots/cartesian/CartesianCoordinateSystem.cpp:32:0:
/usr/include/c++/6.0.0/cmath:655:5: note:   ‘std::isnan’
     isnan(_Tp __x)
     ^~~~~


Use <math.h> there instead of <cmath> in src/backend/worksheet/plots/cartesian/CartesianCoordinateSystem.cpp.
Comment 5 Upstream Release Monitoring 2016-02-17 04:00:21 UTC 
nonamedotc's LabPlot-2.1.0-5.fc24 completed http://koji.fedoraproject.org/koji/buildinfo?buildID=736469
Comment 6 Mukundan Ragavan 2016-02-17 04:01:43 UTC 
Thanks a ton, Yaakov! Appreciate the help very much!