Bug 1307310

Summary: airtsp: FTBFS in rawhide
Product: [Fedora] Fedora Reporter: Fedora Release Engineering <releng>
Component: airtspAssignee: Denis Arnaud <denis.arnaud_fedora>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 24CC: denis.arnaud_fedora, yselkowi
Target Milestone: ---Keywords: Patch, Reopened
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: airtsp-1.01.3-1.fc25 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-01-21 19:21:24 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1305208    
Attachments:
Description Flags
build.log
none
root.log
none
state.log
none
Fix FTBFS with GCC 6 (#1307310) none

Description Fedora Release Engineering 2016-02-13 21:00:08 UTC
Your package airtsp failed to build from source in current rawhide.

http://koji.fedoraproject.org/koji/taskinfo?taskID=12805728

For details on mass rebuild see https://fedoraproject.org/wiki/Fedora_24_Mass_Rebuild

Comment 1 Fedora Release Engineering 2016-02-13 21:00:10 UTC
Created attachment 1124000 [details]
build.log

Comment 2 Fedora Release Engineering 2016-02-13 21:00:12 UTC
Created attachment 1124001 [details]
root.log

Comment 3 Fedora Release Engineering 2016-02-13 21:00:13 UTC
Created attachment 1124002 [details]
state.log

Comment 4 Yaakov Selkowitz 2016-02-23 19:04:15 UTC
/builddir/build/BUILD/airtsp-1.01.2/airtsp/command/TravelSolutionParser.cpp:73:41: error: cannot convert 'std::basic_istream<char>' to 'bool' in assignment
         hasRead = (iStringStr >> dvalStr);
                                         ^
/builddir/build/BUILD/airtsp-1.01.2/airtsp/command/TravelSolutionParser.cpp:77:38: error: cannot convert 'std::basic_istream<char>::__istream_type {aka std::basic_istream<char>}' to 'bool' in assignment
         hasRead = (iStringStr >> dval);
                                      ^

See "Cannot convert 'std::ostream' to 'bool'" in https://gcc.gnu.org/gcc-6/porting_to.html

Comment 5 Denis Arnaud 2016-02-24 08:16:33 UTC
Thanks Yaakov!
I'll have a look soon, hopefully next weekend.

Comment 6 Jan Kurik 2016-02-24 14:33:12 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 24 development cycle.
Changing version to '24'.

More information and reason for this action is here:
https://fedoraproject.org/wiki/Fedora_Program_Management/HouseKeeping/Fedora24#Rawhide_Rebase

Comment 7 Yaakov Selkowitz 2016-03-16 04:08:21 UTC
Created attachment 1136836 [details]
Fix FTBFS with GCC 6 (#1307310)

Comment 8 Igor Gnatenko 2017-01-13 06:52:22 UTC
ping?

Comment 9 Denis Arnaud 2017-01-13 12:41:58 UTC
(In reply to Igor Gnatenko from comment #8)
> ping?

Oops, will have a look very soon. Thanks for the follow up!

Comment 10 Denis Arnaud 2017-01-13 18:33:05 UTC
As a matter of fact, the source code was fixed upstream, but no new (upstream) release had been made. Sorry for that. It has now been fixed (ie, the Fedora package integrates the new upstream release, which fixes the compilation issue):
https://koji.fedoraproject.org/koji/taskinfo?taskID=17270344

Comment 11 Upstream Release Monitoring 2017-01-13 18:40:07 UTC
denisarnaud's airtsp-1.01.3-1.fc26 completed http://koji.fedoraproject.org/koji/buildinfo?buildID=833749

Comment 12 Denis Arnaud 2017-01-13 20:31:44 UTC
And successful build for Fedora 25: https://koji.fedoraproject.org/koji/taskinfo?taskID=17270449

Comment 13 Fedora Update System 2017-01-13 20:34:57 UTC
airtsp-1.01.3-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-fe52b0d6bb

Comment 14 Fedora Update System 2017-01-14 06:22:26 UTC
airtsp-1.01.3-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-fe52b0d6bb

Comment 15 Fedora Update System 2017-01-21 19:21:24 UTC
airtsp-1.01.3-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.