Bug 1307322

Created attachment 1124036 [details]
build.log

Created attachment 1124037 [details]
root.log

Created attachment 1124038 [details]
state.log

/builddir/build/BUILD/aqemu-0.8.2/Main_Window.cpp: In member function 'virtual void Main_Window::closeEvent(QCloseEvent*)':
/builddir/build/BUILD/aqemu-0.8.2/Main_Window.cpp:216:43: error: invalid initialization of reference of type 'const QString&' from expression of type 'bool'
        tr("Cannot Save Settings!"), false );
                                           ^

This looks like "Cannot convert 'bool' to 'T*'" in https://gcc.gnu.org/gcc-6/porting_to.html

(In reply to Yaakov Selkowitz from comment #4)
> /builddir/build/BUILD/aqemu-0.8.2/Main_Window.cpp: In member function
> 'virtual void Main_Window::closeEvent(QCloseEvent*)':
> /builddir/build/BUILD/aqemu-0.8.2/Main_Window.cpp:216:43: error: invalid
> initialization of reference of type 'const QString&' from expression of type
> 'bool'
>         tr("Cannot Save Settings!"), false );
>                                            ^
> 
> This looks like "Cannot convert 'bool' to 'T*'" in
> https://gcc.gnu.org/gcc-6/porting_to.html

Thanks, I am going to have to find some downtime to go through these - probably over the weekend. Unfortunately upstream for this project is long since dormant, but I will try and do it enough to get it into F24 and then potentially orphan/retire in F25.

These fix the initial error noted in comment # 4:

master: http://pkgs.fedoraproject.org/cgit/rpms/aqemu.git/commit/?id=d41a317c988d430900c69fe4ba37c289417cccaa
F24: http://pkgs.fedoraproject.org/cgit/rpms/aqemu.git/commit/?h=f24&id=d41a317c988d430900c69fe4ba37c289417cccaa

Unfortunately this brings us to:

/builddir/build/BUILD/aqemu-0.8.2/VM.cpp: In member function 'bool Virtual_Machine::Load_VM(const QString&)':
/builddir/build/BUILD/aqemu-0.8.2/VM.cpp:4566:108: error: no matching function for call to 'QDomElement::firstChildElement(bool)'
     SPICE.Use_Video_Stream_Compression( Second_Element.firstChildElement( ! "Use_Video_Stream_Compression" ).text() == "false" );
                                                                                                            ^
In file included from /usr/include/QtXml/QDomDocument:1:0,
                 from /builddir/build/BUILD/aqemu-0.8.2/VM.cpp:29:
/usr/include/QtXml/qdom.h:234:17: note: candidate: QDomElement QDomNode::firstChildElement(const QString&) const
     QDomElement firstChildElement(const QString &tagName = QString()) const;
                 ^~~~~~~~~~~~~~~~~
/usr/include/QtXml/qdom.h:234:17: note:   no known conversion for argument 1 from 'bool' to 'const QString&'
/builddir/build/BUILD/aqemu-0.8.2/VM.cpp:4598:100: error: no matching function for call to 'QDomElement::firstChildElement(bool)'
     SPICE.Use_Playback_Compression( Second_Element.firstChildElement( ! "Use_Playback_Compression" ).text() == "false" );
                                                                                                    ^
In file included from /usr/include/QtXml/QDomDocument:1:0,
                 from /builddir/build/BUILD/aqemu-0.8.2/VM.cpp:29:
/usr/include/QtXml/qdom.h:234:17: note: candidate: QDomElement QDomNode::firstChildElement(const QString&) const
     QDomElement firstChildElement(const QString &tagName = QString()) const;
                 ^~~~~~~~~~~~~~~~~
/usr/include/QtXml/qdom.h:234:17: note:   no known conversion for argument 1 from 'bool' to 'const QString&'
CMakeFiles/aqemu.dir/build.make:1212: recipe for target 'CMakeFiles/aqemu.dir/VM.o' failed
make[2]: *** [CMakeFiles/aqemu.dir/VM.o] Error 1

This bug appears to have been reported against 'rawhide' during the Fedora 24 development cycle.
Changing version to '24'.

More information and reason for this action is here:
https://fedoraproject.org/wiki/Fedora_Program_Management/HouseKeeping/Fedora24#Rawhide_Rebase

OK, that's just weird negating a string like that, because the result is obviously false, which prior to C++11 would be converted to a null pointer with a warning:

/builddir/build/BUILD/aqemu-0.8.2/VM.cpp:4566:108: warning: converting 'false' to pointer type for argument 1 of 'QString::QString(const char*)' [-Wconversion-null]

The Qt4 documentation states wrt firstChildElement():

> Returns the first child element with tag name tagName if tagName is non-empty;
> otherwise returns the first child element.

Either the negated string was meant as a form of comment:

     SPICE.Use_Video_Stream_Compression( Second_Element.firstChildElement( /* "Use_Video_Stream_Compression" */ ).text() == "false" );
     SPICE.Use_Playback_Compression( Second_Element.firstChildElement( /* "Use_Playback_Compression" */ ).text() == "false" );

Or the negations don't actually belong there.  I'm not familiar enough with the code to tell which, but it was previously being compiled as the former.

Alright, finally found some spare time to dig into this and in my travels came across this:

https://sourceforge.net/p/aqemu/patches/9/

Which I in turn found from:

https://retracile.net/blog/2014/12/29/19.00

This matches the conclusion I had come to after staring at it for a while which is that the ! doesn't belong there at all. Working on applying the fix now.

aqemu-0.8.2-17.fc24 fixes the FTBFS issues - running it however indicates Bug # 1268553 also needs resolution to get something useful.

aqemu-0.8.2-17.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-1a2a5a72f7

aqemu-0.8.2-17.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-1a2a5a72f7

aqemu-0.8.2-18.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-1a2a5a72f7

aqemu-0.8.2-18.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-1a2a5a72f7

aqemu-0.8.2-18.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.