Bug 1307366

Summary: calf: FTBFS in rawhide
Product: [Fedora] Fedora Reporter: Fedora Release Engineering <releng>
Component: calfAssignee: Gwyn Ciesla <gwync>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 24CC: brendan.jones.it, gwync, yselkowi
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-02-25 17:12:23 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1305208    
Attachments:
Description Flags
build.log
none
root.log
none
state.log none

Description Fedora Release Engineering 2016-02-13 21:06:47 UTC
Your package calf failed to build from source in current rawhide.

http://koji.fedoraproject.org/koji/taskinfo?taskID=12808679

For details on mass rebuild see https://fedoraproject.org/wiki/Fedora_24_Mass_Rebuild

Comment 1 Fedora Release Engineering 2016-02-13 21:06:49 UTC
Created attachment 1124168 [details]
build.log

Comment 2 Fedora Release Engineering 2016-02-13 21:06:50 UTC
Created attachment 1124169 [details]
root.log

Comment 3 Fedora Release Engineering 2016-02-13 21:06:51 UTC
Created attachment 1124170 [details]
state.log

Comment 4 Jan Kurik 2016-02-24 14:35:40 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 24 development cycle.
Changing version to '24'.

More information and reason for this action is here:
https://fedoraproject.org/wiki/Fedora_Program_Management/HouseKeeping/Fedora24#Rawhide_Rebase

Comment 5 Yaakov Selkowitz 2016-02-24 23:56:21 UTC
lv2gui.cpp: In function 'void* extgui_instantiate(const _LV2UI_Descriptor*, const char*, const char*, LV2UI_Write_Function, LV2UI_Controller, void**, const LV2_Feature* const*)':
lv2gui.cpp:585:16: error: cannot convert 'bool' to 'LV2UI_Handle {aka void*}' in return
         return false;
                ^~~~~

See "Cannot convert 'bool' to 'T*'" in https://gcc.gnu.org/gcc-6/porting_to.html

Comment 6 Gwyn Ciesla 2016-02-25 14:56:24 UTC
I switched to NULL, which worked, and allowed me to get to this:

modules.cpp: In member function 'virtual bool calf_plugins::analyzer_audio_module::get_graph(int, int, float*, int, calf_plugins::cairo_iface*, int*) const':
modules.cpp:1430:74: error: no matching function for call to 'max(float, double)'
                                     fabs(fft_outL[_iter]) - var1L , 1e-20);
                                                                          ^

I know it's related to the <algorithm> header but I can't make out what I'm missing.

Comment 7 Gwyn Ciesla 2016-02-25 16:06:24 UTC
Ah, progress. . .

Comment 8 Yaakov Selkowitz 2016-02-25 16:09:35 UTC
modules.cpp:1430:74: error: no matching function for call to 'max(float, double)'
                                     fabs(fft_outL[_iter]) - var1L , 1e-20);

That needs to be cast, e.g. float(1e-20)

Comment 9 Gwyn Ciesla 2016-02-25 17:12:23 UTC
I used that for make_pair, but for max I converted to >?:.

Thanks!