Bug 1307749

Summary: logrotate: FTBFS in rawhide
Product: [Fedora] Fedora Reporter: Fedora Release Engineering <releng>
Component: logrotateAssignee: Jan Kaluža <jkaluza>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 24CC: jkaluza, yselkowi
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: logrotate-3.9.2-3.fc24 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-03-01 05:28:09 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 1305208    
Attachments:
Description Flags
build.log
none
root.log
none
state.log none

Description Fedora Release Engineering 2016-02-13 21:49:32 UTC
Your package logrotate failed to build from source in current rawhide.

http://koji.fedoraproject.org/koji/taskinfo?taskID=12833296

For details on mass rebuild see https://fedoraproject.org/wiki/Fedora_24_Mass_Rebuild

Comment 1 Fedora Release Engineering 2016-02-13 21:49:35 UTC
Created attachment 1125308 [details]
build.log

Comment 2 Fedora Release Engineering 2016-02-13 21:49:36 UTC
Created attachment 1125309 [details]
root.log

Comment 3 Fedora Release Engineering 2016-02-13 21:49:38 UTC
Created attachment 1125310 [details]
state.log

Comment 4 Jan Kurik 2016-02-24 14:53:24 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 24 development cycle.
Changing version to '24'.

More information and reason for this action is here:
https://fedoraproject.org/wiki/Fedora_Program_Management/HouseKeeping/Fedora24#Rawhide_Rebase

Comment 5 Yaakov Selkowitz 2016-02-25 16:54:23 UTC
logrotate.c: In function 'postrotateSingleLog':
logrotate.c:1787:2: error: statement is indented as if it were guarded by... [-Werror=misleading-indentation]
  if (!hasErrors && log->flags & LOG_FLAG_TMPFILENAME) {
  ^~
logrotate.c:1784:5: note: ...this 'if' clause, but it is not
     if (!state->doRotate)
     ^~
logrotate.c:1824:2: error: statement is indented as if it were guarded by... [-Werror=misleading-indentation]
  if (selinux_enabled) {
  ^~
logrotate.c:1820:5: note: ...this 'if' clause, but it is not
     if (!hasErrors && rotNames->disposeName)
     ^~

New warning in GCC 6, and package builds with -Werror.  The code should either be fixed if there is a legitimate issue, or build without -Werror (or at least with -Wno-error=misleading-indentation)

Comment 6 Yaakov Selkowitz 2016-03-01 05:28:09 UTC
This was fixed before branching.