Bug 1308311

Summary: [RFE] support builds without gnome-vfs
Product: [Fedora] Fedora Reporter: Steve <y9t7sypezp>
Component: inkscapeAssignee: Gwyn Ciesla <gwync>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: duffy, gwync, jonathan.underwood, lkundrak
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-02-15 12:01:44 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
inkscape.spec patch showing changes needed to build without gnome-vfs
none
proposed inkscape.spec patch to allow building without gnome-vfs none

Description Steve 2016-02-14 07:36:14 UTC 
Created attachment 1126965 [details]
inkscape.spec patch showing changes needed to build without gnome-vfs

Description of problem:
The Fedora build of Inkscape pulls in gnome-vfs2 and gvfs as dependencies. I do not want to install those packages, but when attempting to rebuild Inkscape from source, I found that those dependencies cannot be disabled without changing inkscape.spec.

The attached patch shows how I modified inkscape.spec to complete the build. It is NOT a proposed fix. NB: I changed some other lines to keep rpmlint happy.

Version-Release number of selected component (if applicable):
inkscape-0.91-20.fc24.src.rpm
Built on an F23 system.

Additional info:
Bug 1307203 - Inkscape pulls in gvfs

NB: Inkscape crashes while dereferencing a NULL pointer, if certain configuration files[1] are not installed. I believe the crash is an unrelated bug that is exposed when Inkscape has not been previously installed or when Inkscape has been removed.

[1] $ ls -1 /usr/share/inkscape/ui/*
/usr/share/inkscape/ui/menus-bars.xml
/usr/share/inkscape/ui/toolbox.xml
/usr/share/inkscape/ui/units.xml
Comment 1 Steve 2016-02-14 07:47:53 UTC 
The "Import Clip Art ..." menu item is present, and the dialog is displayed, but it is not functional. When a search term is entered, there are no network transactions. The menu item should probably not be listed, if the dialog is not functional.

See also:
Bug 653516 - Inkscape should not require deprecated GnomeVFS
Comment 2 Steve 2016-02-15 01:11:07 UTC 
Created attachment 1127144 [details]
proposed inkscape.spec patch to allow building without gnome-vfs

This patch should allow Inkscape to be built with gnome-vfs by default and without gnome-vfs with the rpmbuild option "--without gnome-gvs".

Test cases:
$ rpmbuild --nobuild inkscape.spec
$ rpmbuild --nobuild --without gnome-gvs inkscape.spec
$ rpmbuild --nobuild --with gnome-gvs inkscape.spec

Tests should be done with and without gnome-vfs2-devel installed.

Notes:
1. I left in a debug echo to show that the two conditions are handled.
2. This change suppresses an rpmbuild warning:
-#%{_datadir}/inkscape/clipart
+#%%{_datadir}/inkscape/clipart
Comment 3 Steve 2016-02-15 01:25:07 UTC 
(In reply to Steve from comment #2)
...
> This patch should allow Inkscape to be built with gnome-vfs by default and
> without gnome-vfs with the rpmbuild option "--without gnome-gvs".
> 
> Test cases:
> $ rpmbuild --nobuild inkscape.spec
> $ rpmbuild --nobuild --without gnome-gvs inkscape.spec
> $ rpmbuild --nobuild --with gnome-gvs inkscape.spec

Urk! It's gnome-vfs. I didn't read my own test results. :-(

Tests without gnome-vfs2-devel installed, so the errors are expected:

$ rpmbuild --nobuild inkscape.spec 
opt_gnome_vfs: '--with-gnome-vfs'
error: Failed build dependencies:
	gnome-vfs2-devel >= 2.0 is needed by inkscape-0.91-20.fc23.x86_64

$ rpmbuild --nobuild --without gnome-vfs inkscape.spec 
opt_gnome_vfs: '--without-gnome-vfs'

$ rpmbuild --nobuild --with gnome-vfs inkscape.spec 
opt_gnome_vfs: '--with-gnome-vfs'
error: Failed build dependencies:
	gnome-vfs2-devel >= 2.0 is needed by inkscape-0.91-20.fc23.x86_64
Comment 4 Jonathan Underwood 2016-02-15 12:01:44 UTC 
I have removed the dependency on gnome-vfs from the rawhide (F24) package.
Comment 5 Steve 2016-02-15 17:54:23 UTC 
(In reply to Jonathan Underwood from comment #4)
> I have removed the dependency on gnome-vfs from the rawhide (F24) package.

Thanks, Jonathan. That's even better.[1] And thanks for cleaning up the spec file.

[1] http://pkgs.fedoraproject.org/cgit/rpms/inkscape.git/commit/inkscape.spec?id=4fc0e61bd3a44c786ff470b7ca0532355d22602c