Bug 1308416

Summary: [Bug] /var/run/virt-who.pid is world-writable
Product: Red Hat Enterprise Linux 6 Reporter: Adi Akbar <aakbar>
Component: virt-whoAssignee: Radek Novacek <rnovacek>
Status: CLOSED ERRATA QA Contact: gaoshang <sgao>
Severity: high Docs Contact:
Priority: unspecified    
Version: 6.7CC: hsun, ovasik, rbalakri, shihliu
Target Milestone: rc   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: virt-who-0.16-5.el6 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-05-10 23:57:30 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Adi Akbar 2016-02-15 06:56:36 UTC 
Description of problem:

/var/run/virt-who.pid is world-writable

Version-Release number of selected component (if applicable):

RHEL 6.7 running virt-who-0.12-10.el6.noarch

How reproducible:

Always

Steps to Reproduce:
1).Install and Configure virt-who on a server in a VM environment.
2. Start virt-who service
3. Check for the permissions of the PID file created.

Actual results:

PID File created by virt-who is world writable.

Expected results:

PID File created by virt-who should not be world writable.

Reference Case # 01582525
Comment 2 Radek Novacek 2016-02-23 13:28:05 UTC 
Fixed upstream:

https://github.com/virt-who/virt-who/commit/4ddbb759cace9c2c31aec021cdb157712d46b56c
Comment 3 Radek Novacek 2016-02-23 14:35:05 UTC 
Fixed in virt-who-0.16-5.el6.
Comment 5 Liushihui 2016-03-01 09:21:46 UTC 
Checked it on virt-who-0.16-5.el6.noarch. the authority has update to 600. 
Can we modify it to 644?
[root@hp-z220-07 run]# ll /var/run/virt-who.pid
-rw-------. 1 root root 4 Mar  1 16:46 /var/run/virt-who.pid
Comment 6 Radek Novacek 2016-03-08 16:07:11 UTC 
Is there any reason why it should be 644? Why should non-root processes be able to read virt-who PID?
Comment 7 Liushihui 2016-03-16 06:30:49 UTC 
No special reason, I think the pid is not secret and other related service also show 644. Anyway, I will verify it.
[root@intel-piketon-01 ~]# ll /var/run/libvirtd.pid
-rw-r--r--. 1 root root 5 Mar 16 02:27 /var/run/libvirtd.pid
Comment 9 errata-xmlrpc 2016-05-10 23:57:30 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHEA-2016-0859.html