| Summary: | renrot fails with Can't use 'defined(%hash)' | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Michael <linux> |
| Component: | renrot | Assignee: | Charles R. Anderson <cra> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 24 | CC: | andy.shevchenko, cra, mathias.f |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | noarch | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | renrot-1.2.0-1.fc25 renrot-1.2.0-1.fc24 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-02-09 04:20:08 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
*** Bug 1087027 has been marked as a duplicate of this bug. *** This message is a reminder that Fedora 23 is nearing its end of life. Approximately 4 (four) weeks from now Fedora will stop maintaining and issuing updates for Fedora 23. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '23'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 23 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. Bug still exists in Fedora 24. This bug is fixed in upstream renrot-1.2.0. Please update ( see bug #1409691). EPEL 6 & 7 have renrot-1.2.0 already. This package has changed ownership in the Fedora Package Database. Reassigning to the new owner of this component. renrot-1.2.0-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-15149f3ef8 renrot-1.2.0-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-c9d649d09e renrot-1.2.0-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-15149f3ef8 renrot-1.2.0-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-c9d649d09e Tested in Fedora 25. Looks good, many thanks! renrot-1.2.0-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. renrot-1.2.0-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. |
Description of problem: renrot fails with an error, see below. % renrot -e nef --no-rotate -n '%Y%m%d-%H%M%S-00%c' Can't use 'defined(%hash)' (Maybe you should just omit the defined()?) at /usr/bin/renrot line 44 (#1) (F) defined() is not usually right on hashes. Although defined %hash is false on a plain not-yet-used hash, it becomes true in several non-obvious circumstances, including iterators, weak references, stash names, even remaining true after undef %hash. These things make defined %hash fairly useless in practice, so it now generates a fatal error. If a check for non-empty is what you wanted then just put it in boolean context (see "Scalar values" in perldata): if (%hash) { # not empty } If you had defined %Foo::Bar::QUUX to check whether such a package variable exists then that's never really been reliable, and isn't a good way to enquire about the features of a package, or whether it's loaded, etc. Can't use 'defined(%hash)' (Maybe you should just omit the defined()?) at /usr/bin/renrot line 44. Aborted at /usr/bin/renrot line 9. main::__ANON__ called at /usr/share/perl5/diagnostics.pm line 570 diagnostics::death_trap("Can't use 'defined(%hash)' (Maybe you should just omit the de"...) called at /usr/bin/renrot line 44 Version-Release number of selected component (if applicable): % dnf info renrot Name : renrot Arch : noarch Epoch : 0 Version : 1.1 Release : 3.fc23.11 How reproducible: always. Steps to Reproduce: 1. pick up some JPGs, NEF, whatever. 2. call 'renrot -e jpg' ("jpg" must match the extension of your files) Actual results: renrot exits with error, see above. Expected results: Images should be rotated and renamed according to EXIF information. Additional info: Same problem was in Debian 2 years ago, see https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=729630