Bug 1308430

Summary:	Cleaning up old tasks, sync status wrongly shows repos "Never synced"
Product:	Red Hat Satellite	Reporter:	Pavel Moravec <pmoravec>
Component:	Repositories	Assignee:	satellite6-bugs <satellite6-bugs>
Status:	CLOSED WONTFIX	QA Contact:	Katello QA List <katello-qa-list>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	Nightly	CC:	aperotti, aruzicka, ktordeur, mklika, sauchter
Target Milestone:	Unspecified	Keywords:	Triaged
Target Release:	Unused
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-08-02 20:59:58 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Pavel Moravec 2016-02-15 08:37:32 UTC

Description of problem:
Applying patch from bz1289384, and running the cleanup script with AFTER=.. longer than a repo has been synced, Sync Status page shows the repo has not been synced ever.

I suggest this improvement: in case "Never synced" is about to appear, check if pulp repo has been synced, i.e. by running:

pulp-admin repo tasks list --repo-id <id>

(and finding newest sync operation)

or by querying repo_sync_results collection in mongodb (somehow via pulp, I guess)


Version-Release number of selected component (if applicable):
Sat6.2 / Sat6.1.6 patched by bz1289384 (foreman-tasks commit fb88f07)


How reproducible:
100%


Steps to Reproduce:
1. Sync a repo >1 day ago
2. foreman-rake foreman_tasks:cleanup AFTER=1d FILTER=
3. Check Sync status in WebUI


Actual results:
3. shows the repo "Never synced"


Expected results:
3. to show same info like before (without the cleanup script called)


Additional info:
kudos to Nikola Stiasni who discovered this bug.

Comment 2 Bryan Kearney 2016-07-26 15:25:24 UTC

Moving 6.2 bugs out to sat-backlog.

Comment 3 Bryan Kearney 2016-07-26 15:36:07 UTC

Moving 6.2 bugs out to sat-backlog.

Comment 5 Stuart Auchterlonie 2016-09-09 11:04:44 UTC

Would it not make sense to maintain the sync status as part of the metadata of
the repository?

Comment 6 Pavel Moravec 2016-09-09 11:15:34 UTC

(In reply to Stuart Auchterlonie from comment #5)
> Would it not make sense to maintain the sync status as part of the metadata
> of
> the repository?

I think repository metadata are generated only when publishing the repository, what is a different pulp action than repo sync. It usually (always?) follows repo sync, though.

Moreover, repo metadata are AFAIK just written to the disk under /var/lib/pulp and just pulp knows the proper location. It would be weird to get info about latest repo sync (katello request) from something written by pulp to the disk..

Comment 7 Stuart Auchterlonie 2016-09-09 11:52:22 UTC

Here's me thinking we stored that info in the database somewhere :)

Comment 8 Adam Ruzicka 2017-11-22 14:28:01 UTC

This needs to be handled on katello's side. We need to somehow stop relying on tasks always being there and store the needed data ourselves.

Comment 9 Bryan Kearney 2018-08-02 20:59:58 UTC

Thank you for your interest in Satellite 6. We have evaluated this request, and we do not expect this to be implemented in the product in the forseeable future. We are therefore closing this out as WONTFIX. If you have any concerns about this, please feel free to contact Rich Jerrido or Bryan Kearney. Thank you.