Bug 1308481

Summary: test suite fails on machine with lots of cpu cores
Product: [Fedora] Fedora EPEL Reporter: Tuomo Soini <tis>
Component: quantum-espressoAssignee: marcindulak <Marcin.Dulak>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: epel7CC: Marcin.Dulak
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: quantum-espresso-5.3.0-8.el6 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-03-09 15:00:23 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Tuomo Soini 2016-02-15 10:43:10 UTC
Description of problem:

Test suite takes rediculous time to complete on test machine with 24 visible cpu cores because %check doesn't honor %{_smp_ncpus_max} setting

Version-Release number of selected component (if applicable):

quantum-espresso-5.3.0-5.el7
quantum-espresso-5.3.0-5.el6

How reproducible:

Always. 12h mock timeout always stops build.

Fix:

%_smp_ncups_max 8

And following change to spec:

diff --git a/quantum-espresso.spec b/quantum-espresso.spec
index 83160b4..f3a0735 100644
--- a/quantum-espresso.spec
+++ b/quantum-espresso.spec
@@ -322,6 +322,10 @@ mv test-suite test-suite.orig
 MPI_SUFFIX=_serial %docheck
 
 NPROC=`cat /proc/cpuinfo | grep processor | wc -l`
+%if 0%{?_smp_ncpus_max}
+[ ${NPROC} -gt %{?_smp_ncpus_max} ] && NPROC=%{?_smp_ncpus_max}
+%endif
+export NPROC
 
 # all parallel tests use mpirun
 sed -i '/unset PARA_PREFIX/d' environment_variables

Comment 1 Tuomo Soini 2016-02-15 10:55:09 UTC
Forgot to add 5.3.0-7.* versions are affected too.

Comment 2 Fedora Update System 2016-02-19 20:58:52 UTC
quantum-espresso-5.3.0-8.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-9f04d158ef

Comment 3 Fedora Update System 2016-02-19 20:59:35 UTC
quantum-espresso-5.3.0-8.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-72ad34fd5f

Comment 4 Fedora Update System 2016-02-19 21:00:14 UTC
quantum-espresso-5.3.0-8.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-109b4f4605

Comment 5 Fedora Update System 2016-02-19 21:00:44 UTC
quantum-espresso-5.3.0-8.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-e2250a6387

Comment 6 marcindulak 2016-02-19 21:19:24 UTC
In this case I think it is better to hard-limit the number of processes used for tests to 2. 8 might be already slowing down the tests if one uses hyperthreading on 4 physical cores.

Comment 7 Tuomo Soini 2016-02-19 21:32:20 UTC
Very true. Thank you.

Comment 8 Fedora Update System 2016-02-21 06:21:22 UTC
quantum-espresso-5.3.0-8.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-72ad34fd5f

Comment 9 Fedora Update System 2016-02-21 06:53:28 UTC
quantum-espresso-5.3.0-8.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-9f04d158ef

Comment 10 Fedora Update System 2016-02-21 17:58:43 UTC
quantum-espresso-5.3.0-8.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-e2250a6387

Comment 11 Fedora Update System 2016-02-21 18:27:50 UTC
quantum-espresso-5.3.0-8.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-109b4f4605

Comment 12 Fedora Update System 2016-03-09 14:27:38 UTC
quantum-espresso-5.3.0-8.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.

Comment 13 Fedora Update System 2016-03-09 15:00:20 UTC
quantum-espresso-5.3.0-8.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.

Comment 14 Fedora Update System 2016-03-09 15:55:31 UTC
quantum-espresso-5.3.0-8.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

Comment 15 Fedora Update System 2016-03-09 16:23:10 UTC
quantum-espresso-5.3.0-8.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.

Comment 16 Fedora Update System 2016-03-09 20:12:53 UTC
quantum-espresso-5.3.0-8.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.

Comment 17 Fedora Update System 2016-03-09 20:14:06 UTC
quantum-espresso-5.3.0-8.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.